New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated method printnl() slightly in the package PDF::Create::Page. #1

Merged
merged 2 commits into from Sep 17, 2015

Conversation

Projects
None yet
2 participants
@manwar
Owner

manwar commented Sep 1, 2015

Hi,

As a part of PR Challenge, I propose minor changes to the method printnl() in the package PDF::Create::Page.

Please review.

Best Regards,
Mohammad S Anwar

@manwar

This comment has been minimized.

Show comment
Hide comment
@manwar

manwar Sep 5, 2015

Owner

It seems you missed my another commit as below:

4c389e0

This resolves the issue.you raised.

Owner

manwar commented Sep 5, 2015

It seems you missed my another commit as below:

4c389e0

This resolves the issue.you raised.

@szabgab

This comment has been minimized.

Show comment
Hide comment
@szabgab

szabgab Sep 17, 2015

Collaborator

I am going to merge this as this seems to be harmless, but then I also think it does not add a lot of value (if any) to the code base.

I think if you'd like your contribution to really matter, then you should create some more meaningful PR.
For example fixing one of the reported bugs or checking tests coverage and adding more tests where we are missing them.

Collaborator

szabgab commented Sep 17, 2015

I am going to merge this as this seems to be harmless, but then I also think it does not add a lot of value (if any) to the code base.

I think if you'd like your contribution to really matter, then you should create some more meaningful PR.
For example fixing one of the reported bugs or checking tests coverage and adding more tests where we are missing them.

szabgab added a commit that referenced this pull request Sep 17, 2015

Merge pull request #1 from Manwar/minor-changes-to-method-printnl
updated method printnl() slightly in the package PDF::Create::Page.

@szabgab szabgab merged commit 9c90a43 into manwar:master Sep 17, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment