RFC109: fix inifinite loop on metadata substitutions (#4877)

MapServer · Mar 10, 2014 · 99db0ee · 99db0ee
1 parent f1b98e9
commit 99db0ee
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/mapfile.c b/mapfile.c
@@ -6658,8 +6658,9 @@ static void hashTableSubstituteString(hashTableObj *hash, const char *from, cons
   key = msFirstKeyFromHashTable(hash);
   while(key != NULL) {
     val = msLookupHashTable(hash, key);
-    if(!strcasestr(val, from)) continue;
-    msInsertHashTable(hash, key, msCaseReplaceSubstring(msStrdup(val), from, to));
+    if(strcasestr(val, from)) {
+      msInsertHashTable(hash, key, msCaseReplaceSubstring(msStrdup(val), from, to));
+    }
     key = msNextKeyFromHashTable(hash, key);
   }
 }