New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using POLYLINE_NO_CLIP with Inline feature can result in a seg fault #4676
Comments
Please provide a backtrace of the crash, or a testcase. I think this should be investigated at the AGG level rather than looking for a workaround. |
The solution is not a workaround, but something that is missing with inline layers. All other drivers already skip the feature that are not in the map extent (in WhichShape). Currently, all inline features are drawn, which is very not optimal. That said, I'll also attach a testcase to allow you to fix the agg crash. |
I've committed the improvement in master. @tbonfort let me know if you have any objection if I backport this in branch-6-2. About the AGG crash, you can reproduce it by downloading the following mapfile and shp2img (checkout the revision before my patch): http://dl.mapgears.com/ab-tmp/4676.map
|
Will check the msautotest failure... |
Keeping this one open as there clearly is an issue with AGG when shape coordinates are magnitudes out of image bounds. Low priority though, demilestoning. |
This is an automated commentThis issue has been closed due to lack of activity. This doesn't mean the issue is invalid, it simply got no attention within the last year. Please reopen with missing/relevant information if still valid. Typically, issues fall in this state for one of the following reasons:
|
When using a inline layer with the POLYLINE_NO_CLIP processing option, AGG crashes if the feature X and Y are completely outside the extend requested.
Solution: For a INLINE layer, the searchrect will be stored in the layerinfo and a bounds check will be added in msLayerNextShape().
The text was updated successfully, but these errors were encountered: