Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing svg symbol cause assert #4899

Closed
fblackburn opened this issue Mar 28, 2014 · 4 comments
Closed

Missing svg symbol cause assert #4899

fblackburn opened this issue Mar 28, 2014 · 4 comments
Assignees
@tbonfort
Labels
Bug C Library
Milestone
6.4.2 release

Comments

@fblackburn
Copy link

Referencing a missing svg file in a symbol definition cause an assert. The assert message says: "mapserv: (mapserver directory)/mapcairo.c:998: msRenderRasterizedSVGSymbol: Assertion `svg_cache->pixmap_buffer->height && svg_cache->pixmap_buffer->width' failed.".
fblackburn pushed a commit to fblackburn/mapserver that referenced this issue Mar 28, 2014
Fix empty svg assert (MapServer#4899)
31ab9bc 
* Added a return ms_failure when symbol svg file path doesn't point on an existing file
* Removed the assert in the freeSVGCache function of mapcairo.c
@fblackburn
Copy link
Author

Referenced by pull request #4900

tbonfort pushed a commit that referenced this issue Mar 29, 2014
@tbonfort
Fix failed assertion with non-existant svg symbols (#4899)
83e4ee8
@tbonfort
Copy link
Member

Applied without the unrelated cosmetic changes in 83e4ee8

@tbonfort tbonfort added this to the 6.4.2 release milestone Mar 29, 2014
@tbonfort tbonfort self-assigned this Mar 29, 2014
@fblackburn
Copy link
Author

Using a mapfile with a missing SVG symbol in it still cause an assert in the "freeSVGCache" function on line 1039 of "mapcairo.c". I realise I did a poor job at explaining the second part of my pull request (#4900) but it was supposed to fix this assert.

tbonfort added a commit that referenced this issue Apr 1, 2014
@tbonfort
add missing check for #4899
75a5408
@tbonfort
Copy link
Member

tbonfort commented Apr 1, 2014

Sorry, I've added the check in 75a5408 . I'm leaving in the assertion as it would be a bug needing fixing if the renderer_cache came in with a NULL svg handle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tbonfort tbonfort

Labels
Bug C Library
Projects
None yet
Milestone
6.4.2 release
Development

No branches or pull requests
2 participants
@tbonfort @fblackburn