WFS Server featureid parameter doesn't like typename containing a dot.

[gsueur]

when playing with this kind of request :
https://download.data.grandlyon.com/wfs/grandlyon?SERVICE=WFS&REQUEST=GetFeature&typename=fpc_fond_plan_communaut.fpcbaticonstruction&VERSION=2.0.0&featureid=fpc_fond_plan_communaut.fpcbaticonstruction.1

if your typename contains a dot, it doesn't work. You have this message : msWFSGetFeature(): WFS server error. Invalid FeatureId in GetFeature. Expecting layername.value : fpc_fond_plan_communaut.fpcbaticonstruction.1

Best regards

[tomkralidis]

👍 I'm facing the same issue.

[gsueur]

And it ain't cool for Inspire harmonized layer names...

[sdlime]

Are the dots legal in a layer/type name? I assume yes, and if so it should be a relatively easy fix around line 2326 in mapwfs.c. We'd need to change that conditional to be nTokens1 >= 2 and then change the next bit of code to be more generic to push the last token onto the aFIDValues array and the proceeding tokens (joined on a .) onto the aFIDLayers array. --Steve

[gsueur]

In a MapServer point of view I don't know, but it is mandatory in some context like INSPIRE in Europe. See http://boundlessgeo.com/2012/04/inspire-harmonized-layer-names-in-geoserver/ for example.

[tomkralidis]

It's legal to have dots.

[sdlime]

I’ll try and post a patch later today. --Steve

From: Tom Kralidis [mailto:notifications@github.com]
Sent: Tuesday, May 13, 2014 10:11 AM
To: mapserver/mapserver
Cc: Lime, Steve D (MNIT)
Subject: Re: [mapserver] WFS Server featureid parameter doesn't like typename containing a dot. (#4925)

It's legal to have dots.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/4925#issuecomment-42968007.

[sdlime]

I posted a patch against the 6.4 branch here: http://maps1.dnr.state.mn.us/test/mapserver/4925.patch. It's untested but it's a pretty straight forward fix.I see that Even also has included a fix in a recent commit that's probably more efficient. Can someone test?

[jratike80]

Test with Mapserver 7.0 with Spatialite data source. Success with request:
http://localhost:8060/cgi-bin/mapserv.exe?map=c:/ms4w/apps/wms-wfs.map&service=wfs&version=1.1.0&request=getfeature&typename=states.table&featureid=states.table.2