-
-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHP mapscript 7.0.0 ms_newGridObj appears non-functional #5159
Comments
Can anyone verify this? |
I had a suspicion that the GRID block was not being created with ms_newGridObj. If it's any indication, saving out the map object to a mapfile sure enough shows the complete absence of the GRID block. As a workaround, I'm temporarily using updateFromString to programmatically inject the GRID block. |
please provide a minimal php script that exhibits the behavior |
|
Caused by the changes in #4913 . Assigning to @szekerest |
Could someone check if the commit above is working? |
Checking.... |
i get the same issue with master, on windows, with that test script (GRID object is not written to the mapfile). |
@szekerest posted a proposed fix in his clone in 57f9ecb but nobody tried it out. it has not been merged into master or branch-7-0 as it hasn't been tested. |
good lord i just spent 2 hours getting master to work here. umm....can you apply this to master so it is easier to test? |
not applying to master before someone actually confirms it fixes the issue given tamas couldn't test.
|
for windows i have to make many custom changes, for my builds to work (especially for the mapscripts). It is hard to explain. |
then let @dshorthouse test the fix. this isn't windows specific. |
I confirm this fix (manually, with files from @szekerest 's clone). The resulting map image contains grid lines. The resulting map layer does contain a GRID object:
|
Thanks @jmckenna for confirming the fix. Apologies for not being able to do it myself. I'll let others close the fix once it's pulled into master. |
applied to branch-7-0 in 4dacec0 |
I upgraded to 7.0.0 from 6.4.2 and I cannot get ms_newGridObj to work in PHP mapscript, which was working just fine. No errors are thrown with the same code - just no GRID no matter what I attempt. When I use shp2img using a barebones map file however, GRID does work.
The text was updated successfully, but these errors were encountered: