Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC109: Refactor Runtime Substitution Methods #4877

Merged
merged 1 commit into from Mar 7, 2014
Merged

RFC109: Refactor Runtime Substitution Methods #4877

merged 1 commit into from Mar 7, 2014

Conversation

tbonfort
Copy link
Member

@tbonfort tbonfort commented Mar 3, 2014

  • Rewrite substitution loops to first check for available VALIDATION
    patterns before looping through KVP pairs. This is possible because
    VALIDATIONs are mandatory, and speeds things up substantially in the
    general case when there are few/no substitutions to apply
  • Allow runtime substitutions to apply to map->metadata,
    layer->metadata, and all outputformat->formatoptions

@tbonfort tbonfort added this to the 7.0 Release milestone Mar 3, 2014
@tbonfort tbonfort self-assigned this Mar 3, 2014
tbonfort added a commit to MapServer/MapServer-documentation that referenced this pull request Mar 3, 2014
tbonfort added a commit to MapServer/msautotest_DEPRECATED that referenced this pull request Mar 7, 2014
- Rewrite substitution loops to first check for available VALIDATION
  patterns before looping through KVP pairs. This is possible because
  VALIDATIONs are mandatory, and speeds things up substantially in the
  general case when there are few/no substitutions to apply

- Allow runtime substitutions to apply to map->metadata,
  layer->metadata, and all outputformat->formatoptions
@tbonfort tbonfort merged commit c4542bc into MapServer:master Mar 7, 2014
tbonfort added a commit to MapServer/MapServer-documentation that referenced this pull request Mar 7, 2014
tbonfort added a commit to MapServer/msautotest_DEPRECATED that referenced this pull request Mar 8, 2014
tbonfort added a commit that referenced this pull request Mar 8, 2014
zidge pushed a commit to mapsherpa/mapserver that referenced this pull request Mar 10, 2014
- Rewrite substitution loops to first check for available VALIDATION
  patterns before looping through KVP pairs. This is possible because
  VALIDATIONs are mandatory, and speeds things up substantially in the
  general case when there are few/no substitutions to apply

- Allow runtime substitutions to apply to map->metadata,
  layer->metadata, and all outputformat->formatoptions
zidge pushed a commit to mapsherpa/mapserver that referenced this pull request Mar 10, 2014
zidge pushed a commit to mapsherpa/mapserver that referenced this pull request Mar 10, 2014
tbonfort added a commit to MapServer/msautotest_DEPRECATED that referenced this pull request Mar 11, 2014
tbonfort added a commit to MapServer/msautotest_DEPRECATED that referenced this pull request Mar 11, 2014
tbonfort added a commit that referenced this pull request Mar 11, 2014
don't print error messages in regex/validation checks, the higher level
callers already print one out. also add back debugging messages in the
debug logs.
tbonfort added a commit to MapServer/msautotest_DEPRECATED that referenced this pull request Feb 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant