Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WCS20 extensions #4898

Closed
wants to merge 23 commits into from
Closed

Conversation

constantinius
Copy link
Contributor

@constantinius constantinius commented Mar 28, 2014

When WCS 2.0 was implemented in MapServer, much of the functionality of previous WCS versions was not standardized, due to the Core/Extension model of the WCS 2.0 specification. Now some extensions are finally ratified or about to be ratified.

This pull request implements the following WCS 2.0 Extensions:

Test cases will also be included in msautotest.

@constantinius
Copy link
Contributor Author

constantinius commented Mar 31, 2014

Requires changes for msautotest: MapServer/msautotest_DEPRECATED#26

@tbonfort
Copy link
Member

tbonfort commented Apr 1, 2014

@constantinius as discussed during the code sprint, ping me via this issue once you're ready to have this one merged into master. cheers.

@constantinius
Copy link
Contributor Author

constantinius commented Apr 1, 2014

@tbonfort: I guess its pretty complete. How can we set up a test with travis?

Once it passes, maybe we could merge msautotest first and rewrite the .gitmodules to point to the mapserver/msautotest instead of our fork.

@tbonfort
Copy link
Member

tbonfort commented Apr 2, 2014

@constantinius you should update your git submodule to point to a git:// or https:// url rather than an ssh one, as the latter is not readable without your private ssh key.

@tbonfort
Copy link
Member

tbonfort commented Apr 2, 2014

hmm, actually that's not the issue. is the EOX-A repo public ?

@constantinius
Copy link
Contributor Author

constantinius commented Apr 2, 2014

@tbonfort: yes, should be. I'll update the .gitmodules to use https://

@tbonfort
Copy link
Member

tbonfort commented Apr 2, 2014

actually I don't really understand why it's failing. You are correctly referencing a git:// url, but travis-ci is trying an ssh update:

Cloning into 'msautotest'...
Warning: Permanently added 'github.com,192.30.252.129' (RSA) to the list of known hosts.
Permission denied (publickey).
fatal: Could not read from remote repository.
Please make sure you have the correct access rights
and the repository exists.
Clone of 'git@github.com:EOX-A/msautotest.git' into submodule path 'msautotest' failed

Aside from that, I cannot test this locally as there is no 1b84ea66c210f181f760 commit in the EOX-A repo

constantinius and others added 3 commits Apr 2, 2014
Using https:// rather than the git:// URL prefix.
Added a submodule sync for tryout.
tbonfort pushed a commit that referenced this pull request Apr 2, 2014
- Add parsing capabilities for WCS RangeSubset extension.
- Implement WCS geotiff extension.
- Properly implement CRS extension.
- Fix Profile URIs for WCS 2.0
- Fix subsettingcrs KVP parameter name.
- Proper implementation of scale extension.
- Fix index for rangesubset intervals. Also allowing integers as band identifiers.
- Fix geotiff:predictor parameter. Should now be one of 'None', 'Horizontal' or 'FloatingPoint' as required in the spec.
@tbonfort
Copy link
Member

tbonfort commented Apr 2, 2014

rebased and squashed into d246a0b

@tbonfort tbonfort closed this Apr 2, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants