Label outline not changing when OUTLINEWIDTH value changed #5107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cnieman can you confirm all is OK with this patch? |
|
I just did a quick test and it looks OK. It's not exactly the same as my build before the fix for #4942, but I assume that things are a bit wrong in that build for the outline widths. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a mapfile that has several layers that use SIZEUNITS METERS for styling the layers. Specific to this issue is that the layers are labelled. The text seems to be sized properly in meters, but the outline on the text is not. It seems to always be the same no matter what value I set OUTLINEWIDTH to.
Sample mapfile: https://www.dropbox.com/s/rg9bph3awkmujr2/outlinewidth.map?dl=0
This seems to have started happening after the fix for #4942.
I checked out 3e7ecf7, and the problem did not happen, but checking out d0043f2 makes it happen. It also happens with an up-to-date branch-7-0