Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Legend MapServer 7.0.1 Label OFFSET is not supported anymore #5267

Closed
wants to merge 1 commit into from
Closed

Legend MapServer 7.0.1 Label OFFSET is not supported anymore #5267

wants to merge 1 commit into from

Conversation

tbonfort
Copy link
Member

@tbonfort tbonfort commented Aug 27, 2016

After MapServer update from version 6.4 to version 7.0 or 7.01 OFFSET in LEGEND Block does not work anymore.

MapServer 6.4
In my mapfile, the LABEL of my LEGEND is adjusted by specifying an OFFSET in the LABEL-block.

LEGEND-block in the Mapfile (Mapserver 6.4.1):

  • The OFFSET of 0 -10 centers the LABEL of the LEGEND: legend_mapserv_6_offset.png
    legend_mapserv_6_offset
  • Without the OFFSET in the LABEL-Block it looks like this (label is a not in the center, but at the bottom: legend_mapserv_6_without_offset.png
    legend_mapserv_6_without_offset
LEGEND
    STATUS ON
    KEYSIZE 30 30
    KEYSPACING 5 3  
    LABEL
        TYPE TRUETYPE
        FONT 'arial' 
        SIZE 10
        COLOR 119 179 0
        OFFSET 0 -10
    END 
END 

MapServer 7.0.1

  • After the update to version 7 the OFFSET in the LEGEND is ignored and the label no longer appears in the center: legend_mapserv_7_offset.png

legend_mapserv_7_offset

LEGEND
    STATUS ON
    KEYSIZE 30 30
    KEYSPACING 5 3  
    LABEL
        TYPE TRUETYPE
        FONT 'arial' 
        SIZE 10
        COLOR 119 179 0
        OFFSET 0 -10
    END 
END  

I tested this with the MapServer 7.0.1 on the new OSGeo-Live.

@tbonfort
Copy link
Member

tbonfort commented Aug 27, 2016

I've added a tentative fix to the current PR, please check it out

@jmckenna
Copy link
Member

jmckenna commented Sep 15, 2016

@astroidex can you confirm that thomas' fix posted here, works in your case?

@jmckenna
Copy link
Member

jmckenna commented Sep 19, 2016

@astroidex can you confirm that thomas' fix posted here, works in your case? Or, can you post the sample mapfile + data, so I can test?

@jmckenna
Copy link
Member

jmckenna commented Sep 20, 2016

@astroidex can you confirm that thomas' fix posted here, works in your case? Or, can you post the sample mapfile + data, so I can test? (I'd like to get this included in the MapServer 7.0.2 release this week)

@astroidex
Copy link
Contributor Author

astroidex commented Sep 21, 2016

@jmkenna I added the mapfiles here (coy of your demo mapfile) #5332
Thanks for pushing it. Have to find time to compile & test...

tbonfort added a commit that referenced this pull request Sep 21, 2016
tbonfort pushed a commit that referenced this pull request Sep 21, 2016
@tbonfort
Copy link
Member

tbonfort commented Sep 21, 2016

applied to branch-7-0, alongside test

@tbonfort tbonfort closed this Sep 21, 2016
tbonfort pushed a commit that referenced this pull request Sep 21, 2016
@astroidex
Copy link
Contributor Author

astroidex commented Oct 7, 2016

OFFSET works now, but it does not position the text regularly. The distance between the texte rows is sometimes different.

See images

  • sgk_ms6 4 3 - how it is displayed in MapServer 6.4.3

sgk_ms6 4 3

  • sgk_ms7 0 2 - how it is displayed in MapServer 7.0.2

sgk_ms7 0 2

@honoref
Copy link

honoref commented Nov 30, 2018

I have the same vertical offset between icons and text. It's because height of texts are calculate the more short arround the text, and with differents texts, high are differents.
character g is heigher than character o. And even if the character 8 as the same height than g, they are not align o8g. Mapserver align each text on the top.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants