Vector Tile Support #5376
Vector Tile Support #5376
Conversation
…sion 2 of the spec.
mapmvt.c
Outdated
| VectorTile__Tile mvt_tile = VECTOR_TILE__TILE__INIT; | ||
| mvt_tile.layers = msSmallCalloc(map->numlayers,sizeof(VectorTile__Tile__Layer*)); | ||
|
|
||
|
|
There was a problem hiding this comment.
@sdlime, I see why you were getting alignment issues. This block of code needs to be kept, however the query.rect should be extended before the query, as is done in the WFS part: 032e5d3#diff-8b3f151aa0bfca8681cd277ced6c85cfR2619 . I know this isn't clean, but the buffering logic (similar to metabuffering when tiling) is essential IIRC for correct rendering.
…MVT writing function and pulled it from the templating code.
…s things properly.
…msMVTSetup(), not necessary for WMS of mode=tile operation.
Reverse Geometry with mvtReverseRingDirection only if MS_LAYER_POLYGON, trying to solve sdlime/mvt-demo#2
Update mapmvt.c
…that works and then we'll take care of the others.
|
I am really keen to get this running as soon as possible and have a project just waiting for this functionality. I am not sure if I can help but if there is something I can do to help get this functionality running I am happy to put in some time/effort. |
|
@rouault where the integration tests are crapping out doesn't look to be failing because my pull request (it's generating a PNG), is there a way to examine the Travis or AppVeyor output files? --Steve |
|
@sdlime I'm not aware of a way of extracting the files from Travis/AppVeyor. I'd just suggest that you run msautotest from Vagrant, which uses the same library version as Travis. That's what I do usually |
|
@rouault what version of vagrant and virtual box are you using? Stefan's docs reference versions that are a tad old. |
|
The ones of Ubuntu 16.04: vagrant 1.8.1 + virtualbox 5.0.40. But the versions of ubuntu 14.04 also worked |
|
@rouault, a local vagrant up dies since it can't find protobufc yet Travis seems to have that installed. Do you know where to affect that? --Steve |
|
@sdlime In scripts/vagrant/packages.sh, add libprotobuf-dev or whatever the package is named to the apt-get install final line |
…emerge select protobuf bits
Restore CMakeList.txt to its state before #5376 merge, and remerge select protobuf bits
|
Compiled on Windows X64 platform and can confirm it is all working - there are some issues around Windows support for protobuf-c however I found a precompiled Windows binary that seems to work (See details here: protobuf-c/protobuf-c#168 - download provided at the end of the comments). I have tested it with the mvt-demo published by @sdlime and will now start working on my data and looking at mapscript operation. Thanks guys great work and perfect timing for getting this running. |
set required syntax statement for protobuf 3 (#5376)
Based on Thomas' vector-tiles branch. Fixed an alignment issue, added integration with mode=tile and updated to version 2.1 or the spec - basically switched out the .proto file. Tested against a couple of the Leaflet mvt plugins. --Steve
TODO: