Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Python test for checking the OFFSET is output correctly #5715

Merged
merged 5 commits into from Feb 27, 2020

Conversation

geographika
Copy link
Member

@thisIsShubhamSharma - I added a Python test to create a style with doubles as OFFSET values, convert it to a string, load it back and check the doubles are still there. The test however appears to be failing. Can you convert to string and see that double OFFSET values are preserved?

          output_string = new_style.convertToString()
          new_style2 = mapscript.fromstring(output_string)
      
          # ensure attributes are output as doubles
          assert new_style.size == 7.25
  >       assert new_style2.offsetx == 10.5
  E       AssertionError: assert 0.0 == 10.5
  E        +  where 0.0 = <mapscript.mapscript.styleObj; proxy of <Swig Object of type 'styleObj *' at 0x03ED0A10> >.offsetx

@geographika geographika reopened this Jan 25, 2019
@geographika geographika changed the base branch from master to branch-7-2 January 25, 2019 07:55
@geographika geographika changed the base branch from branch-7-2 to master January 27, 2019 07:09
@geographika geographika reopened this Feb 27, 2020
@rouault rouault merged commit b79ced1 into MapServer:master Feb 27, 2020
@geographika
Copy link
Member Author

For reference issue was #5310 and fix was by @sdlime with #5738

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants