Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSSQL2008: deal with termination '$' at end of regular expression. Follow-up of eea166a5157d4742b617cd7561c62cd2df5c8f5c (refs #5825) #5841

Merged
merged 1 commit into from Jul 30, 2019

Conversation

rouault
Copy link
Contributor

@rouault rouault commented Jul 26, 2019

@geographika I believe this should do it, but couldn't test. I'd appreciate if you could report if it solves your issue

We should probably add mssql tests in msautotest. Relevant snippets from GDAL autotest suite: https://github.com/OSGeo/gdal/blob/master/gdal/ci/travis/ubuntu_1604/before_install.sh#L10 and https://github.com/OSGeo/gdal/blob/master/gdal/ci/travis/ubuntu_1604/before_install.sh#L46

@geographika
Copy link
Member

geographika commented Jul 26, 2019

@rouault - many thanks, that removed the $ and the LIKE queries are working again. I didn't realise it was an issue with the MSSQL driver only.

Yes the MSSQL driver could do with some tests / testdb. I forgot we could also test on Linux now as well. I'll try and get something running in the next couple of months.

@geographika geographika merged commit d2e0517 into MapServer:master Jul 30, 2019
rouault added a commit that referenced this pull request Jul 30, 2019
…llow-up of eea166a (refs #5825) (#5841)

Tested and confirm this fixes the issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants