Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styling - Fixes alpha value for hex colors #6023

Merged
merged 3 commits into from Apr 1, 2020

Conversation

ravhed
Copy link
Contributor

@ravhed ravhed commented Mar 26, 2020

Fixes issue #5882. The issue was introduced by the following commit:

4fbd7ae

This commit changes back to the old behavior so that opacity is only
applied if the style have any bindings. A test case to test this
has also been added.

Fixes issue MapServer#5882. The issue was introduced by the following commit:

MapServer@4fbd7ae

This commit changes back to the old behavior so that opacity is only
applied if the style have any bindings. A test case to test this
has also been added.
@ravhed
Copy link
Contributor Author

ravhed commented Mar 26, 2020

It seems like some SLD tests fail. I will have to investigate those.

@jmckenna jmckenna added this to the 7.6.1 Release milestone Mar 27, 2020
@jbo-ads
Copy link
Member

jbo-ads commented Mar 30, 2020

Looks like I am the one who introduced that regression. I'll take a look at SLD tests.

@jbo-ads
Copy link
Member

jbo-ads commented Mar 30, 2020

I just submitted changes in SLD tests to ravhed:hex-opacity branch, see ravhed#1.

Fix SLD tests
@ravhed
Copy link
Contributor Author

ravhed commented Mar 30, 2020

I just submitted changes in SLD tests to ravhed:hex-opacity branch, see ravhed#1.

Thanks a lot for your help! I haven't had time to look at the tests myself.

@jmckenna
Copy link
Member

jmckenna commented Mar 30, 2020

@jbo-ads would this bug also affect branch-7-6 code? Just wondering the impact.

@jmckenna jmckenna modified the milestones: 7.6.1 Release, 7.6 Release Mar 30, 2020
@jbo-ads
Copy link
Member

jbo-ads commented Mar 30, 2020

@jmckenna Yes, the bug was present since my first SLD changes.

@jmckenna
Copy link
Member

jmckenna commented Mar 30, 2020

ok thanks @jbo-ads

@jmckenna jmckenna added the SLD label Mar 31, 2020
@rouault rouault merged commit eb6a62e into MapServer:master Apr 1, 2020
2 checks passed
@rouault
Copy link
Contributor

rouault commented Apr 1, 2020

@jbo-abs I let you issue a backport PR to 7.6 branch

@jmckenna jmckenna added the backport branch-7-6 To backport a pull request to branch-7-6 label Apr 4, 2020
jmckenna pushed a commit that referenced this pull request Apr 5, 2020
Fixes #5882. The issue was introduced by the following commit:

4fbd7ae

This commit changes back to the old behavior so that opacity is only
applied if the style have any bindings. A test case to test this
has also been added.
@jmckenna
Copy link
Member

jmckenna commented Apr 5, 2020

cherry-picked into branch-7-6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport branch-7-6 To backport a pull request to branch-7-6 SLD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants