Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #5508 - Revived ANTIALIAS keyword in STYLE section #6225

Merged
merged 3 commits into from
Feb 3, 2021

Conversation

rouault
Copy link
Contributor

@rouault rouault commented Feb 3, 2021

#5514 rebased on top of latest master with tab fixes and addition of expected results

@jmckenna
Copy link
Member

jmckenna commented Feb 3, 2021

thanks @rouault for also including the new tests

@geographika
Copy link
Member

I had this listed for removal in https://mapserver.org/development/rfc/ms-rfc-133.html - I guess this should not be the case.

Docs currently talk about the GD renderer:

Should TrueType fonts be antialiased. Only useful for GD (gif) rendering. Default is false. Has no effect for the other renderers (where anti-aliasing can not be turned off).

Would the following be correct?

Should antialiasing be applied to the style? For line rendering only

@rouault
Copy link
Contributor Author

rouault commented Feb 3, 2021

Would the following be correct?

Should antialiasing be applied to the style? For line rendering only

looks good to me

@jmckenna
Copy link
Member

jmckenna commented Feb 3, 2021

thanks @rouault and @erik-h11 !!

@jmckenna jmckenna merged commit cdc71ac into MapServer:main Feb 3, 2021
@rouault
Copy link
Contributor Author

rouault commented Feb 3, 2021

thanks @rouault and @erik-h11 !!

I would have used the "squash & merge" button to have a cleaner commit history

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants