-
-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove PHP-native MapScript code for 8.0 release #6430
Conversation
jmckenna
commented
Oct 28, 2021
•
edited
Loading
edited
- part of the MapServer 8.0 release plan (https://github.com/MapServer/MapServer/wiki/MapServer-8.0-Release-Plan)
- as PHP-native MapScript is unmaintained and now causing constant security concerns & efforts
- as PHP 7 & 8 are now well supported by SWIG
- see issue Fails to build with PHP 8.0 #6201 for PHP 8.0 progress with SWIG MapScript
- this pull request:
- removes old native PHP MapScript
- updates TravisCI and GitHub build action to use Ubuntu Focal
- builds PHPNG MapScript for PHP 7.4.6, 8.0.19, 8.1.6
- builds Python MapScript for Python 3.7.7, 3.8.3, 3.9.0
- updates many msautotest tests
- updates all PHP unit tests
|
the test failures are due to php references in top |
…into php-native-eol
|
@jmckenna I see that ubuntugis has updated the GDAL version to 3.4.3 which explains the need to regenerate some files. Regarding the remaining last failures, do I understand correctly from your commit comment you've run the Docker recipee to update the files ? I could give it another try if you wish (I remember some oddity during my previous commits where some generated TIFF files were not binary identical between Docker and Vagrant also using the same GDAL version) |
|
@rouault yes I've run this through Docker (as I am battling the latest UbuntuGIS changes as you mentioned), and those last 4 'alternative' files committed are from the Docker container...I was examining why those 4 alternative files aren't being accepted (I see that they should pass using this |
|
@rouault as you wrote this, I was exactly comparing the binary NetCDF files, as to why those 4 alternative files aren't passing..... does this follow what you were asking? I think what you suggested is exactly what I am doing. Am I on the correct track? |
yes, thanks. Your approach looks good. Just let me know if you need a second look/try on this. (Up to now, the Docker approach was convenient to be able to locally reproduce. Contrary to Travis-CI which has preinstalled components not always easy to reproduce) |
ah good, thanks, deal. |
…iles, which it ignored up to now
|
jmckenna#3 solves the issue with the .nc test files (the build now fail later on the PHP tests) |
ah thanks!!! |
msautotest: update netCDF related results
|
thanks for everyone's help through this. Merging (for the beta this coming Friday!) |