Skip to content

remove PHP-native MapScript code for 8.0 release #6430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 125 commits into from
Jun 15, 2022

Conversation

jmckenna
Copy link
Member

@jmckenna jmckenna commented Oct 28, 2021

  • part of the MapServer 8.0 release plan (https://github.com/MapServer/MapServer/wiki/MapServer-8.0-Release-Plan)
  • as PHP-native MapScript is unmaintained and now causing constant security concerns & efforts
  • as PHP 7 & 8 are now well supported by SWIG
  • this pull request:
    • removes old native PHP MapScript
    • updates TravisCI and GitHub build action to use Ubuntu Focal
    • builds PHPNG MapScript for PHP 7.4.6, 8.0.19, 8.1.6
    • builds Python MapScript for Python 3.7.7, 3.8.3, 3.9.0
    • updates many msautotest tests
    • updates all PHP unit tests

@jmckenna jmckenna added this to the 8.0 Release milestone Oct 28, 2021
@rouault
Copy link
Contributor

rouault commented Oct 28, 2021

the test failures are due to php references in top Makefile

@rouault
Copy link
Contributor

rouault commented Jun 14, 2022

@jmckenna I see that ubuntugis has updated the GDAL version to 3.4.3 which explains the need to regenerate some files. Regarding the remaining last failures, do I understand correctly from your commit comment you've run the Docker recipee to update the files ? I could give it another try if you wish (I remember some oddity during my previous commits where some generated TIFF files were not binary identical between Docker and Vagrant also using the same GDAL version)

@jmckenna
Copy link
Member Author

@rouault yes I've run this through Docker (as I am battling the latest UbuntuGIS changes as you mentioned), and those last 4 'alternative' files committed are from the Docker container...I was examining why those 4 alternative files aren't being accepted (I see that they should pass using this .alternative extension, through line 88 of testlib.py. I'm not sure your question exactly, but yes I am currently updating all of this to match the latest UbuntuGIS changes. Did I answer your question? Sorry, ha, I'm deep into this, my words aren't making sense here :)

@jmckenna
Copy link
Member Author

@rouault as you wrote this, I was exactly comparing the binary NetCDF files, as to why those 4 alternative files aren't passing..... does this follow what you were asking? I think what you suggested is exactly what I am doing. Am I on the correct track?

@rouault
Copy link
Contributor

rouault commented Jun 14, 2022

Did I answer your question?

yes, thanks. Your approach looks good. Just let me know if you need a second look/try on this. (Up to now, the Docker approach was convenient to be able to locally reproduce. Contrary to Travis-CI which has preinstalled components not always easy to reproduce)

@jmckenna
Copy link
Member Author

yes, thanks. Your approach looks good. Just let me know if you need a second look/try on this. (Up to now, the Docker approach was convenient to be able to locally reproduce. Contrary to Travis-CI which has preinstalled components not always easy to reproduce)

ah good, thanks, deal.

@rouault
Copy link
Contributor

rouault commented Jun 14, 2022

jmckenna#3 solves the issue with the .nc test files (the build now fail later on the PHP tests)

@jmckenna
Copy link
Member Author

jmckenna#3 solves the issue with the .nc test files (the build now fail later on the PHP tests)

ah thanks!!!

@jmckenna
Copy link
Member Author

thanks for everyone's help through this. Merging (for the beta this coming Friday!)

@jmckenna jmckenna merged commit 3a100ab into MapServer:main Jun 15, 2022
@jmckenna jmckenna changed the title WIP: remove PHP-native MapScript code for 8.0 release remove PHP-native MapScript code for 8.0 release Aug 9, 2022
@geographika geographika mentioned this pull request Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants