Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collection of backports from the 8.0 development work. #6818

Merged
merged 15 commits into from
Feb 5, 2023

Conversation

sdlime
Copy link
Member

@sdlime sdlime commented Feb 3, 2023

These will contribute increased stability and security. Specifically:

- https://github.com/MapServer/MapServer/pull/6584  
- https://github.com/MapServer/MapServer/pull/6577
- https://github.com/MapServer/MapServer/pull/6458
- https://github.com/MapServer/MapServer/pull/6466 

Plus fixing (cherrypick) a memory leak discovered while writing OGCAPI tests.

--Steve

sdlime and others added 15 commits October 5, 2022 10:56
* Refactor validation of numeric content read from the mapfile.
* Updated create image function with guard to ensure positive image size (matches Cairo approach).
Addressed issues identified in issue MapServer#6463. Mostly expanding allowed values to account for documentation and adding line numbers to error messages to make debugging easier.
@sdlime
Copy link
Member Author

sdlime commented Feb 3, 2023

@jmckenna, is Travis completely hosed for branch-7-6?

@jmckenna
Copy link
Member

jmckenna commented Feb 3, 2023

@sdlime the history here is that I put much effort into upgrading TravisCI and GitHub action for MapServer 8.0.0 release (and MapCache 1.14.0 also)....I did not devote time into older branches for either MapServer or MapCache. If it's required I can find some time, but I was thinking the priorities were the main branches.

@jmckenna
Copy link
Member

jmckenna commented Feb 3, 2023

short answer: yes, I would ignore CI errors in older branches for MapServer and MapCache.

@sdlime
Copy link
Member Author

sdlime commented Feb 3, 2023

@sdlime the history here is that I put much effort into upgrading TravisCI and GitHub action for MapServer 8.0.0 release (and MapCache 1.14.0 also)....I did not devote time into older branches for either MapServer or MapCache. If it's required I can find some time, but I was thinking the priorities were the main branches.

Oh, I agree with you on priorities. I just wanted to make sure these issues weren't cause by these changes. I don't believe they are...

@jmckenna
Copy link
Member

jmckenna commented Feb 3, 2023

Yes, agreed, darn, it was just about priorities.

@jmckenna
Copy link
Member

jmckenna commented Feb 5, 2023

Thanks Steve, merging now...

@jmckenna jmckenna merged commit 3891125 into MapServer:branch-7-6 Feb 5, 2023
@sdlime sdlime deleted the oktoberfest branch February 9, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants