Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capability: Show pinpoint locations or custom markers on the map #140

Open
Malvoz opened this issue Sep 9, 2019 · 3 comments
Open

Capability: Show pinpoint locations or custom markers on the map #140

Malvoz opened this issue Sep 9, 2019 · 3 comments
Labels
discussion: capability a specific capability or feature: should it be included? what details? should it be a requirement? section: map viewer Capabilities & use cases for declarative map viewer widgets status: editor's draft there's a draft section in the report that corresponds to this discussion

Comments

@Malvoz
Copy link
Member

@Malvoz Malvoz commented Sep 9, 2019

This issue is for discussion of the map viewer capability “Show pinpoint locations or custom markers on the map”.

@Malvoz Malvoz added discussion: capability a specific capability or feature: should it be included? what details? should it be a requirement? section: map viewer Capabilities & use cases for declarative map viewer widgets status: editor's draft there's a draft section in the report that corresponds to this discussion labels Sep 9, 2019
@prushforth
Copy link
Member

@prushforth prushforth commented Sep 25, 2019

I believe this is a required capability. Most Web map frameworks allow you to use GeoJSON (at least) to create custom markers. I think we need to reduce the number of abstractions that are used to implement the functionality, however. By this I mean, for example in Leaflet, you have an object called a "Marker", which represents point locations using icon files. You can provide custom icons etc., however I believe that the "Marker" abstraction is one too many.

We need to support CSS / SVG styling of Simple Features geometries, if I might get to the point, but I guess that argument will be for another issue.

Anyway, instead of being undecided on whether this is a required capability, I think it should be marked as a green requirement.

@AmeliaBR
Copy link
Member

@AmeliaBR AmeliaBR commented Sep 27, 2019

I hadn't really been making any decisions about requirement status yet (other than in the initial sections I drafted as examples). But I agree, displaying marker points on a map is a basic requirement.

That said, we might want to separate out the "custom icon" bit into a separate capability. @nchan0154, did you consider that part when doing your capability review for this section?

@nchan0154
Copy link
Contributor

@nchan0154 nchan0154 commented Sep 28, 2019

@AmeliaBR I hadn't mentioned the custom icon part in my write up but I did take notes on whether or not custom icons were supported when conducting research, so breaking this out into a separate capability should be relatively quick and painless!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion: capability a specific capability or feature: should it be included? what details? should it be a requirement? section: map viewer Capabilities & use cases for declarative map viewer widgets status: editor's draft there's a draft section in the report that corresponds to this discussion
Projects
None yet
Development

No branches or pull requests

4 participants