Skip to content

Fix context menu tabbing #844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
May 8, 2023
Merged

Fix context menu tabbing #844

merged 15 commits into from
May 8, 2023

Conversation

@prushforth
Copy link
Member

@prushforth prushforth commented May 4, 2023 •
edited
Loading

  • merge upstream prettier commits
  • get existing tests working
  • arrow up/down should not scroll the page when moving between context menu items
  • shift+tab should work like ArrowUp
  • add tests that show tabbing works the same as arrow key navigation of context menus
  • test on firefox
  • add tests for preventing scroll on long pages when arrow keys used to navigate context menus
  • add test to show no error occurs when Shift+F10 / contextmenu is pressed on a feature

Closes #835, #846

Jacky0299 and others added 9 commits April 28, 2023 11:34
@Jacky0299
Tab compatible with Arrow key
b8a71b9
@Jacky0299
comment
ec29647
Refactor constants to have somewhat meaningful names
54e878c 
Rename some methods to be more related to what they do
@prushforth
Restore catch-all logic that relates to layer context menu, but is
7f26902 
obscure and complicated.  Use KeyboardEvent.code for its case-insensitive
mnemonics.
@prushforth
Merge main into FixContextTabbing
c7227fe 
    Conflicts:
            src/mapml/handlers/ContextMenu.js
            test/e2e/core/ArrowKeyNavContextMenu.test.js
            test/e2e/core/layerContextMenu.test.js
Fix Firefox issue where Shift+F10 would always display the context
f22b000 
menu near the origin of the map container.
@prushforth
Add tests for tab / shift+tab keyboard navigation of context menus
a48e7ce
Support Shift+Tab equivalent to ArrowUp in map context menu
c784ef4
Support Shift+Tab equivalent to ArrowUp in layer context menu
c4aec03
@prushforth prushforth marked this pull request as ready for review May 5, 2023 16:04
@prushforth prushforth requested a review from AliyanH May 5, 2023 16:04
@prushforth
Copy link
Member Author

prushforth commented May 5, 2023

Hmm still the issue of scrolling the page when arrow keys are pressed, usually it's not noticeable when there's no scroll bars, but when you have scroll bars, arrow keys on a menu get transmitted to the document. Hopefully just a question of preventDefault, tbd. Sorry just ignore until I fix that.

@prushforth prushforth marked this pull request as draft May 5, 2023 16:06
@prushforth prushforth marked this pull request as ready for review May 5, 2023 18:00
@AliyanH
Copy link
Member

AliyanH commented May 5, 2023

Just an error I noticed that is on main also,

@prushforth
Copy link
Member Author

prushforth commented May 5, 2023

Just an error I noticed that is on main also,

OK, I think I can fix that in this PR.

@prushforth prushforth mentioned this pull request May 5, 2023
Closed
AliyanH
AliyanH reviewed May 5, 2023
View reviewed changes
AliyanH
AliyanH reviewed May 5, 2023
View reviewed changes
@prushforth prushforth force-pushed the FixContextTabbing branch from 23e1598 to d4c2f9f Compare May 7, 2023 01:23
@prushforth prushforth merged commit 91401d2 into Maps4HTML:main May 8, 2023
@prushforth prushforth deleted the FixContextTabbing branch May 8, 2023 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AliyanH AliyanH AliyanH left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Tabbing through Context Menu is not synced with arrow keys navigation

3 participants

@prushforth @AliyanH @Jacky0299