Skip to content

Fix context menu tabbing #844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
May 8, 2023
Merged

Fix context menu tabbing #844

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
b8a71b9
Tab compatible with Arrow key
Jacky0299 Apr 28, 2023
ec29647
comment
Jacky0299 Apr 28, 2023
54e878c
Refactor constants to have somewhat meaningful names
May 3, 2023
7f26902
Restore catch-all logic that relates to layer context menu, but is
prushforth May 4, 2023
c7227fe
Merge main into FixContextTabbing
prushforth May 4, 2023
f22b000
Fix Firefox issue where Shift+F10 would always display the context
May 4, 2023
a48e7ce
Add tests for tab / shift+tab keyboard navigation of context menus
prushforth May 4, 2023
c784ef4
Support Shift+Tab equivalent to ArrowUp in map context menu
May 5, 2023
c4aec03
Support Shift+Tab equivalent to ArrowUp in layer context menu
May 5, 2023
e9530df
Prevent default on Arrow keys to prevent unwanted document scrolling
May 5, 2023
01cc7ba
Fix error when Shift+F10 / contextmenu pressed on features
May 5, 2023
92ff233
Fix firefox fix
May 5, 2023
6cd4990
Simplify odd logic - let's see if tests pass...
May 5, 2023
d4c2f9f
Test that error doesn't happen with Shift+F10 on features
prushforth May 7, 2023
401bacd
Test arrow keys on context menu don't trigger page scroll
prushforth May 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading