Adding Faker.Address.brState #6

Closed
wants to merge 7 commits into
from

Conversation

Projects
None yet
4 participants
Contributor

rcmachado commented Nov 7, 2010

No description provided.

Marak commented on 2f338eb Nov 7, 2010

So this is for adding Brazilian states? Looks good to me, will merge soon.

Thanks!

Owner

rcmachado replied Nov 7, 2010

Yes :)

I want also to implements a CPF generator (http://en.wikipedia.org/wiki/Cadastro_de_Pessoas_F%C3%ADsicas), but I don't know in which namespace I will put that. Any Ideas?

Marak replied Nov 7, 2010

I would go ahead and implement the code in whichever namespace you'd like. I'm going to think a bit about the internationalization stuff and perhaps update the API so its a bit more clear.

It might make sense to have separate namespaces for each country / region, but I'd like to think about it a bit more.

I think encoding of states is not UTF-8 :( gives strange characters for me.

Owner

rcmachado replied Aug 14, 2012

Hm, I'm using UTF-8 here:

$ file lib/definitions.js
UTF-8 Unicode C++ program text, with very long lines

Do you have any idea what this could be?

rcmachado added some commits Nov 7, 2010

Adding Faker.Person.brCPF
This function generates a brazilian CPF number (similar to Social Security
number in US)
Merge https://github.com/Marak/Faker.js
Conflicts:
	Faker.js
	Readme.md
	examples/js/Faker.js
	lib/address.js
Merge remote-tracking branch 'upstream/master'
Conflicts:
	Faker.js
	examples/js/Faker.js

Marak commented on 2f338eb Nov 7, 2010

So this is for adding Brazilian states? Looks good to me, will merge soon.

Thanks!

Owner

rcmachado replied Nov 7, 2010

Yes :)

I want also to implements a CPF generator (http://en.wikipedia.org/wiki/Cadastro_de_Pessoas_F%C3%ADsicas), but I don't know in which namespace I will put that. Any Ideas?

Marak replied Nov 7, 2010

I would go ahead and implement the code in whichever namespace you'd like. I'm going to think a bit about the internationalization stuff and perhaps update the API so its a bit more clear.

It might make sense to have separate namespaces for each country / region, but I'd like to think about it a bit more.

I think encoding of states is not UTF-8 :( gives strange characters for me.

Owner

rcmachado replied Aug 14, 2012

Hm, I'm using UTF-8 here:

$ file lib/definitions.js
UTF-8 Unicode C++ program text, with very long lines

Do you have any idea what this could be?

Contributor

FotoVerite commented Aug 13, 2014

No, this pull request is very out of date due to our end being not on top of it. We're thinking of doing a plugin system for new countries. Please resubmit if still interested in including.

@FotoVerite FotoVerite closed this Aug 13, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment