Permalink
Browse files

[api] Plaintext credentials now in use. Added Changelog

  • Loading branch information...
1 parent d9be8d7 commit d06ed1541b88efee7e181a69123f99b6034e095b @bmeck bmeck committed May 24, 2011
Showing with 19 additions and 12 deletions.
  1. +7 −0 Changelog
  2. +6 −6 Readme.md
  3. +2 −2 demo-template.js
  4. +2 −2 demo.js
  5. +2 −2 lib/node_mailer.js
View
@@ -0,0 +1,7 @@
+node_mailer changelog:
+
+0.6.0 [Breaking]
+- Plaintext username/password
+
+0.5.0
+- NodeMailer as backing SmtpClient
View
@@ -34,16 +34,16 @@
subject : "node_mailer test email",
body: "Hello! This is a test of the node_mailer.",
authentication : "login", // auth login is supported; anything else is no auth
- username : "dXNlcm5hbWU=", // Base64 encoded username
- password : "cGFzc3dvcmQ=" // Base64 encoded password
+ username : "my_username", // username
+ password : "my_password" // password
},
function(err, result){
if(err){ console.log(err); }
});
}
# USING SSL
-This fork supports SSL connections (not TLS / STARTTLS, just SSL from the beginning of the connection). To use it,
+This fork supports SSL connections. To use it,
add an option ssl: true. See usage above.
@@ -87,8 +87,8 @@ add an option ssl: true. See usage above.
},
authentication : "login", // auth login is supported; anything else is no auth
- username : "dXNlcm5hbWU=", // Base64 encoded username
- password : "cGFzc3dvcmQ=" // Base64 encoded password
+ username : "my_username", // username
+ password : "my_password" // password
},
function(err, result){
if(err){ console.log(err); }
@@ -99,5 +99,5 @@ add an option ssl: true. See usage above.
## Authors
-Marak Squires, Elijah Insua, Fedor Indutny
+Marak Squires, Elijah Insua, Fedor Indutny, Bradley Meck
View
@@ -22,8 +22,8 @@ for(var i = 0; i < 10; i++){
},
authentication : "login", // auth login is supported; anything else is no auth
- username : "dXNlcm5hbWU=", // Base64 encoded username
- password : "cGFzc3dvcmQ=" // Base64 encoded password
+ username : undefined, // username
+ password : undefined // password
},
function(err, result){
if(err){ console.log(err); }
View
@@ -11,8 +11,8 @@ for(var i = 0; i < 10; i++){
subject : "node_mailer test email",
body: "Hello! This is a test of the node_mailer.",
authentication : "login", // auth login is supported; anything else is no auth
- username : undefined, // Base64 encoded username
- password : undefined // Base64 encoded password
+ username : undefined, // username
+ password : undefined // password
},
function(err, result){
if(err){ console.log(err); }
View
@@ -59,8 +59,8 @@ exports.send = function node_mail(message,callback) {
port: +message.port,
use_authentication: message.authentication,
ssl: message.ssl,
- user: new Buffer(message.username || '', 'base64').toString('utf8'),
- pass: new Buffer(message.password || '', 'base64').toString('utf8'),
+ user: message.username && message.username.toString(),
+ pass: message.password && message.password.toString(),
debug: true
}
if(message.username || message.password) {

0 comments on commit d06ed15

Please sign in to comment.