fix for issue #51 #53

Open
wants to merge 5 commits into
from

Conversation

Projects
None yet
3 participants

admanb commented Nov 7, 2011

credit to travisperson for the fix

dobesv commented Nov 14, 2011

It looks like this patch also includes a conversion to jade instead of mustache. Be careful when merging ... just cherry-pick the 4699790 commit!

admanb commented Nov 14, 2011

Huh. I'm fairly new to github. When I created the pull request I hadn't added the jade conversion. I pushed that in later for my own purposes. Does it always add new commits to any open pull request? Is there any way to avoid that?

dobesv commented Nov 14, 2011

Hi Adam,

I'm pretty new too. It seems like the pull request is tied to a branch so
future commits to the branch are bundled into the request. If you create a
separate branch for the pull request it should be good.

There might be a way to create a pull request from a specific commit or tag
as well, but I haven't done it before and a quick Google doesn't turn
anything up.

On Tue, Nov 15, 2011 at 7:38 AM, Adam Bloom <
reply@reply.github.com

wrote:

Huh. I'm fairly new to github. When I created the pull request I hadn't
added the jade conversion. I pushed that in later for my own purposes. Does
it always add new commits to any open pull request? Is there any way to
avoid that?


Reply to this email directly or view it on GitHub:
#53 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment