Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #71: Make the address of LocalVariable settable #72

Merged
merged 1 commit into from Mar 18, 2017

Conversation

eliben
Copy link
Contributor

@eliben eliben commented Mar 17, 2017

Without this change, it doesn't appear to be possible to use LocalVariable
within a Function on x86_64 at all (see issue #71).

Reject setting the address of subvariables.

@eliben
Copy link
Contributor Author

eliben commented Mar 17, 2017

I guess I could add tests too :) I just didn't find other LocalVariable tests anywhere

Without this change, it doesn't appear to be possible to use LocalVariable
within a Function on x86_64 at all (see issue #71).

Adding a simple test too
@eliben
Copy link
Contributor Author

eliben commented Mar 18, 2017

Rebased following discussion in #71, and added test

@Maratyszcza Maratyszcza merged commit d2c4170 into Maratyszcza:master Mar 18, 2017
@Maratyszcza
Copy link
Owner

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants