Remove old editing modes completly #215

Closed
GoogleCodeExporter opened this Issue Mar 21, 2015 · 10 comments

Comments

Projects
None yet
2 participants
@GoogleCodeExporter
Currently the old "non-EasyEdit"-Modes are still available. Remove them and all 
associated logic.

Branch for this release so that die hards can continue to use the modes and 
back port fixes. 

Original issue reported on code.google.com by sp8...@gmail.com on 16 Mar 2014 at 1:55

@GoogleCodeExporter

This comment has been minimized.

Show comment
Hide comment
@GoogleCodeExporter

GoogleCodeExporter Mar 21, 2015

You cannot be serious about that?

The new default (that EasyEdit stuff) is completely unusable and I even had a 
hard time finding out how to revert Vespucci to a usable state. All I have 
figured out how to do with the new editing mode is breaking the map.

Removing the normal editing capabilities will leave Android with no usable OSM 
editor. Branching is not an option because I surely do not want to build every 
release from source.

Original comment by n...@naturalnet.de on 18 May 2014 at 11:13

You cannot be serious about that?

The new default (that EasyEdit stuff) is completely unusable and I even had a 
hard time finding out how to revert Vespucci to a usable state. All I have 
figured out how to do with the new editing mode is breaking the map.

Removing the normal editing capabilities will leave Android with no usable OSM 
editor. Branching is not an option because I surely do not want to build every 
release from source.

Original comment by n...@naturalnet.de on 18 May 2014 at 11:13

@GoogleCodeExporter

This comment has been minimized.

Show comment
Hide comment
@GoogleCodeExporter

GoogleCodeExporter Mar 21, 2015

I believe you are fairly on your own with your opinion of the EasyEdit mode. 
With the exception of long press to add a node (which is not particularly 
intuitive) it would seem to be very difficult to find any objective reason for 
your statement as well (and you don't actually give any). 

I could make a case for leaving some kind of tag editing only mode around, 
however even that would tend to work better if aligned with the new interface 
(which is inline with general Android design). 

That said, you can continue to use the 0.9.4 branch currently I'm still fixing 
bugs there, however once 0.9.5 is released it is unlikely to be further 
maintained.

Original comment by sp8...@gmail.com on 18 May 2014 at 11:34

I believe you are fairly on your own with your opinion of the EasyEdit mode. 
With the exception of long press to add a node (which is not particularly 
intuitive) it would seem to be very difficult to find any objective reason for 
your statement as well (and you don't actually give any). 

I could make a case for leaving some kind of tag editing only mode around, 
however even that would tend to work better if aligned with the new interface 
(which is inline with general Android design). 

That said, you can continue to use the 0.9.4 branch currently I'm still fixing 
bugs there, however once 0.9.5 is released it is unlikely to be further 
maintained.

Original comment by sp8...@gmail.com on 18 May 2014 at 11:34

@GoogleCodeExporter

This comment has been minimized.

Show comment
Hide comment
@GoogleCodeExporter

GoogleCodeExporter Mar 21, 2015

I'm not particularly thrilled to remove the modes either.

How do we explain how to use the EasyEdit mode to new users or give hints to 
existing users that have forgotten details
without resorting to the web browser?
(The page being bigger then the screen,
 not translated and
 requiring a reliable internet access to load the screenshots out in some remote field.
 The screenshots again being larger then some screens)?

Original comment by Marcus.W...@gmail.com on 19 May 2014 at 5:09

I'm not particularly thrilled to remove the modes either.

How do we explain how to use the EasyEdit mode to new users or give hints to 
existing users that have forgotten details
without resorting to the web browser?
(The page being bigger then the screen,
 not translated and
 requiring a reliable internet access to load the screenshots out in some remote field.
 The screenshots again being larger then some screens)?

Original comment by Marcus.W...@gmail.com on 19 May 2014 at 5:09

@GoogleCodeExporter

This comment has been minimized.

Show comment
Hide comment
@GoogleCodeExporter

GoogleCodeExporter Mar 21, 2015

@Marcus One of the things I want to add for 0.9.5 is at least the tutorial on 
device and display it on new installs which will at least partially address 
your concerns.   

Leaving the old modes around doesn't make the documentation and "how to use" 
situation any better, that is for sure.

Original comment by sp8...@gmail.com on 19 May 2014 at 7:24

@Marcus One of the things I want to add for 0.9.5 is at least the tutorial on 
device and display it on new installs which will at least partially address 
your concerns.   

Leaving the old modes around doesn't make the documentation and "how to use" 
situation any better, that is for sure.

Original comment by sp8...@gmail.com on 19 May 2014 at 7:24

@GoogleCodeExporter

This comment has been minimized.

Show comment
Hide comment
@GoogleCodeExporter

GoogleCodeExporter Mar 21, 2015

@nik@naturalnet.de still waiting for some constructive input on what the issues 
with the current default mode is.....

Original comment by sp8...@gmail.com on 9 Jul 2014 at 7:35

@nik@naturalnet.de still waiting for some constructive input on what the issues 
with the current default mode is.....

Original comment by sp8...@gmail.com on 9 Jul 2014 at 7:35

@GoogleCodeExporter

This comment has been minimized.

Show comment
Hide comment
@GoogleCodeExporter

GoogleCodeExporter Mar 21, 2015

Deferred to 0,9,6 due to lack of input.

Original comment by sp8...@gmail.com on 29 Jul 2014 at 10:29

  • Added labels: Milestone-Release0.9.6
  • Removed labels: Milestone-Release0.9.5
Deferred to 0,9,6 due to lack of input.

Original comment by sp8...@gmail.com on 29 Jul 2014 at 10:29

  • Added labels: Milestone-Release0.9.6
  • Removed labels: Milestone-Release0.9.5
@GoogleCodeExporter

This comment has been minimized.

Show comment
Hide comment
@GoogleCodeExporter

GoogleCodeExporter Mar 21, 2015

Original comment by sp8...@gmail.com on 29 Jul 2014 at 10:32

  • Added labels: Maintainability

Original comment by sp8...@gmail.com on 29 Jul 2014 at 10:32

  • Added labels: Maintainability
@GoogleCodeExporter

This comment has been minimized.

Show comment
Hide comment
@GoogleCodeExporter

GoogleCodeExporter Mar 21, 2015

https://code.google.com/p/osmeditor4android/source/detail?r=880

Both removed modes required special casing in the map drawing class that would 
have had to been refactored for multi-select support.

Original comment by sp8...@gmail.com on 12 Sep 2014 at 11:32

  • Changed state: Started
https://code.google.com/p/osmeditor4android/source/detail?r=880

Both removed modes required special casing in the map drawing class that would 
have had to been refactored for multi-select support.

Original comment by sp8...@gmail.com on 12 Sep 2014 at 11:32

  • Changed state: Started
@GoogleCodeExporter

This comment has been minimized.

Show comment
Hide comment
@GoogleCodeExporter

GoogleCodeExporter Mar 21, 2015

Pushed milestone back

Original comment by sp8...@gmail.com on 15 Nov 2014 at 4:48

  • Added labels: Milestone-Release0.9.7
  • Removed labels: Milestone-Release0.9.6
Pushed milestone back

Original comment by sp8...@gmail.com on 15 Nov 2014 at 4:48

  • Added labels: Milestone-Release0.9.7
  • Removed labels: Milestone-Release0.9.6

@simonpoole simonpoole added this to the 0.9.7 milestone May 19, 2015

@simonpoole simonpoole self-assigned this May 19, 2015

@simonpoole

This comment has been minimized.

Show comment
Hide comment
@simonpoole

simonpoole Aug 27, 2015

Collaborator

6c88a1a (at last)

Collaborator

simonpoole commented Aug 27, 2015

6c88a1a (at last)

@simonpoole simonpoole closed this Aug 27, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment