Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable spider tests if spider changes are detected #145

Merged
merged 1 commit into from Jul 11, 2023

Conversation

vladbogo
Copy link
Collaborator

@vladbogo vladbogo commented Jul 2, 2023

Replaces #101

Copy link
Member

@grooverdan grooverdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor suggestion (optional) but otherwise looks good from my understanding of the functions there.

@@ -178,7 +178,7 @@ f_tarball.addStep(steps.SetPropertyFromCommand(property="mariadb_version", comma
f_tarball.addStep(steps.SetPropertyFromCommand(property="master_branch", command=util.Interpolate("echo " + "%(prop:mariadb_version)s" + " | cut -d'-' -f 2 | cut -d'.' -f 1,2")))
f_tarball.addStep(steps.SetPropertyFromCommand(
property="spider_changed",
command="git diff-tree --no-commit-id --name-only -r HEAD | grep -q 'storage/spider' && echo 'True' || echo 'False'",
command="git diff-tree --no-commit-id --name-only -r HEAD | grep -q 'storage/spider' && echo 'YES' || echo 'NO'",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[ -n $(git diff-tree --no-commit-id --name-only -r HEAD storage/spider) ] && echo 'YES' || echo 'NO'

@vladbogo vladbogo merged commit 0956fb7 into MariaDB:main Jul 11, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants