MDBF-620: Add libpcre3-dev to jammy for asan #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladbogo
approved these changes
Nov 17, 2023
This corrects ASAN failures on 10.4 Marko: The reason is that the old PCRE (which was replaced in 10.5 by MDEV-14024) is really buggy. For ASAN, uninstrumented code is assumed to be good. As only 10.4 needs this, and 10.5+ uses pcre2. With this installed, the ASAN builder should autodetect WITH_PCRE=system. Currently without headers it fails to compile.
auto-merge was automatically disabled
November 17, 2023 22:08
Head branch was modified
grooverdan
force-pushed
the
MDBF-620-pcre3-dev-asan
branch
from
88ccdb8
to
7d6cde7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This corrects ASAN failures on 10.4
Marko:
The reason is that the old PCRE (which was replaced in 10.5 by MDEV-14024) is really buggy. For ASAN, uninstrumented code is assumed to be good.
As only 10.4 needs this, and 10.5+ uses pcre2 and has mechisms to detect pcre2 over pcre(3) aka 8.x.
With this installed, the ASAN builder should autodetect WITH_PCRE=system. Currently without headers it fails to compile.