New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MDBF-447] Add OpenSUSE to CI Docker image. Build OpenSUSE 15 CI Docker image for BuildBot worker #39
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi. Thanks a lot for your contribution. It mainly looks good, but it requires some changes to fit into the new workflow. Please see my review comments. Thank you again!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks a lot cleaner! Great job! However, I have noticed that hadolint complains. If you can solve the issues that would be great (https://github.com/MariaDB/buildbot/runs/7566146568?check_suite_focus=true). Thanks for the contribution!
|
There are 2 issues:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add DL3037 to https://github.com/MariaDB/buildbot/blob/main/.hadolint.yaml to solve the remaining issue.
|
Hi! I see only one last small thing that could be changed, please rename |
|
Hi @fauust , I had the same thoughts about having only one It's interesting that it answered So, I can rename the file to common |
|
Yes please do. Then we will see with next Opensuse version how dificult that is. |
To use this environment for MariaDB build process. NOTES: - The Dockerfile has been adopted from the ./dockerfiles/opensuse-42.dockerfile because it's more concise than ./dockerfiles/opensuse-15.dockerfile and seems to be enough to build MariaDB. - The `gnutls-devel` package has been added.
To use this environment for MariaDB build process.
NOTES:
because it's more concise than ./dockerfiles/opensuse-15.dockerfile and seems
to be enough to build MariaDB.
gnutls-develpackage has been added.