Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MDBF-447] Add OpenSUSE to CI Docker image. Build OpenSUSE 15 CI Docker image for BuildBot worker #39

Merged
merged 1 commit into from Aug 9, 2022

Conversation

AlexPykavy
Copy link
Contributor

To use this environment for MariaDB build process.

NOTES:

  • The Dockerfile has been adopted from the ./dockerfiles/opensuse-42.dockerfile
    because it's more concise than ./dockerfiles/opensuse-15.dockerfile and seems
    to be enough to build MariaDB.
  • The gnutls-devel package has been added.

Copy link
Collaborator

@vladbogo vladbogo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi. Thanks a lot for your contribution. It mainly looks good, but it requires some changes to fit into the new workflow. Please see my review comments. Thank you again!

ci_build_images/opensuse15.Dockerfile Outdated Show resolved Hide resolved
ci_build_images/opensuse15.Dockerfile Outdated Show resolved Hide resolved
ci_build_images/opensuse15.Dockerfile Outdated Show resolved Hide resolved
ci_build_images/opensuse15.Dockerfile Outdated Show resolved Hide resolved
ci_build_images/opensuse15.Dockerfile Outdated Show resolved Hide resolved
ci_build_images/opensuse15.Dockerfile Outdated Show resolved Hide resolved
Copy link
Collaborator

@vladbogo vladbogo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks a lot cleaner! Great job! However, I have noticed that hadolint complains. If you can solve the issues that would be great (https://github.com/MariaDB/buildbot/runs/7566146568?check_suite_focus=true). Thanks for the contribution!

@AlexPykavy
Copy link
Contributor Author

There are 2 issues:

  • the first is related to the zypper clean and I will easily fix it
  • the second is about specifying strict package versions and I can do it but other Dockerfiles don't follow this rule. So, need your opinion on that matter :)

Copy link
Collaborator

@vladbogo vladbogo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add DL3037 to https://github.com/MariaDB/buildbot/blob/main/.hadolint.yaml to solve the remaining issue.

@fauust
Copy link
Collaborator

fauust commented Aug 2, 2022

Hi!
Thanks @AlexPykavy for your contribution, looks good.

I see only one last small thing that could be changed, please rename opensuse15.Dockerfile to opensuse.Dockerfile, we try to keep only one dockerfile per distribution if possible, so, when the next version will be released, we will hopefully be able to use the same Dockerfile.

@AlexPykavy
Copy link
Contributor Author

Hi @fauust ,

I had the same thoughts about having only one opensuse.Dockerfile for all OpenSUSE versions but encountered an issue with 42 version. Namely, I got the following output when calling zypper update -y:

Retrieving repository 'OSS Update' metadata -----------------------------------------------------------------------------------------------------[\]Signature verification failed for file 'repomd.xml' from repository 'OSS Update'.

    Note: Signing data enables the recipient to verify that no modifications occurred after the data
    were signed. Accepting data with no, wrong or unknown signature can lead to a corrupted system
    and in extreme cases even to a system compromise.

    Note: File 'repomd.xml' is the repositories master index file. It ensures the integrity of the
    whole repo.

    Warning: This file was modified after it has been signed. This may have been a malicious change,
    so it might not be trustworthy anymore! You should not continue unless you know it's safe.

Signature verification failed for file 'repomd.xml' from repository 'OSS Update'. Continue? [yes/no] (no): no
Retrieving repository 'OSS Update' metadata .................................................................................................[error]
Repository 'OSS Update' is invalid.
[OSS Update|http://download.opensuse.org/update/leap/42.3/oss/] Valid metadata not found at specified URL
Please check if the URIs defined for this repository are pointing to a valid repository.
Warning: Skipping repository 'OSS Update' because of the above error.
Some of the repositories have not been refreshed because of an error.
Loading repository data...
Warning: Repository 'NON OSS Update' appears to be outdated. Consider using a different mirror or server.
Reading installed packages...

Nothing to do.

It's interesting that it answered no to the prompt despite the fact that I passed -y option. This output may be caused because 42 branch of OpenSUSE reached end of life according to the https://en.wikipedia.org/wiki/OpenSUSE#Version_history.

So, I can rename the file to common opensuse.Dockerfile but chances are that OpenSUSE support may be not as trivial.

@fauust
Copy link
Collaborator

fauust commented Aug 2, 2022

Yes please do. Then we will see with next Opensuse version how dificult that is.

To use this environment for MariaDB build process.

NOTES:
- The Dockerfile has been adopted from the ./dockerfiles/opensuse-42.dockerfile
because it's more concise than ./dockerfiles/opensuse-15.dockerfile and seems
to be enough to build MariaDB.
- The `gnutls-devel` package has been added.
@fauust fauust merged commit 9853498 into MariaDB:main Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants