Crossreference remake #82
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The templates should be under /cr/templates/cr/ instead of the old directory Add all the HTML of the page
After changing the project to follow the Django documentations and tutorials, the directories for the templates needed to be changed.
The static/ directory from the main directory of the project is used to collect all static files from all apps and dump them there. These files are therefore found inside each app of the project under /app_name/static/app_name. Django takes the static files from each apps and places them in a single directory, declared by the STATIC_ROOT variable in the settings.py, to serve them to the user faster.
Add a base template that can be used in other future templates. The base template contains the header banner. Modify and simplify the index.html template to contain only the functionality of the page. Add style for the top header
This ensures that Django knows how to make joins between tables
|
Hi. This LGTM but maybe @cvicentiu or someone else has more experience with Django. From my point of you, you can merge it. |
|
@andreiahendea is this pushed? |
fauust
force-pushed
the
master
branch
2 times, most recently
from
77b6092
to
ed394b7
Compare
fauust
force-pushed
the
master
branch
3 times, most recently
from
18b2f7e
to
ee83d95
Compare
fauust
force-pushed
the
master
branch
10 times, most recently
from
7c3b2ca
to
cd5321a
Compare
|
Moved to MariaDB/buildbot#154 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Crossreference project's structure is remade to comply with the latest practices of Django.
Backend was changed to use the Django ORM, and prevent SQL Injections.
Frontend design was changed to look like mariadb.org.
I tried to make this project as similar to this: http://buildbot.askmonty.org/ci/reports/cross_reference#branch=10.5&revision=&platform=&fail_name=&fail_variant=&fail_info_full=&typ=&info=&dt=14-09-2021&limit=100&fail_info_short=