bb.org: correct tarbuildnum

[grooverdan]

This probably causing errors like https://buildbot.mariadb.org/#/builders/219/builds/1255/steps/3/logs/stdio

sudo sh -c 'echo '\''deb [trusted=yes] https://ci.mariadb.org/1255/amd64-ubuntu-1804-deb-autobake/debs .'\'' >> /etc/apt/sources.list'
....
+ sudo apt-get update
E: Malformed entry 55 in list file /etc/apt/sources.list (Component)
E: The list of sources could not be read.

tarbuildnum is in the scripts (top of https://github.com/MariaDB/mariadb.org-tools/blob/master/buildbot.mariadb.org/scripts/deb-major-upgrade.sh#L7).

I'd like a quick check/deployment monitoring to ensure this is the only impact.

[vladbogo]

This seems to be the problem:

mariadb.org-tools/buildbot.mariadb.org/utils.py

Line 24 in 7076a85

d['tarbuildnum'] = util.Interpolate("%(prop:buildnumber)s")

but I'm not sure if it has implications on other scripts.

[vladbogo]

The tarbuildnum is correctly set without any changes. Based on this PR it will be undefined since the tarball builder doesn't have it set. So, we need to set tarbuildnum as buildnumber. This happens in the tarball builder and sets the property tarbuildnum for all triggered builders with the current buildnumer of the tarball builder.

While indeed in the log, there seems to be an issue, looking at the same build that you point, you can see that the tarbuildnum is correctly set (see below)

So, I susptect to be an issue where the deb scripts looks at the buildnumber and not at the tarbuildnum

[grooverdan]

thanks, I'll keep looking.

[grooverdan]

Found 1a25399 and committed.