From 1c5ae9919463ee0fc1d65fdfc7ec39534495ecaf Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marko=20M=C3=A4kel=C3=A4?= Date: Fri, 14 May 2021 08:36:14 +0300 Subject: [PATCH] MDEV-25666: After backup, "Could not find a valid tablespace file" Ever since MDEV-18518 made DDL operations mostly crash-safe inside InnoDB, it became obvious that Mariabackup might not be entirely safe with regard to concurrent DDL operations. check_if_skip_table(): Do not skip files whose name starts with #sql. We cannot know whether a DDL operation is in progress and the table might in fact be needed later. --- extra/mariabackup/xtrabackup.cc | 4 ---- 1 file changed, 4 deletions(-) diff --git a/extra/mariabackup/xtrabackup.cc b/extra/mariabackup/xtrabackup.cc index 0fa44de8c38e4..4a7bae7fb4129 100644 --- a/extra/mariabackup/xtrabackup.cc +++ b/extra/mariabackup/xtrabackup.cc @@ -2618,10 +2618,6 @@ check_if_skip_table( tbname = ptr + 1; } - if (strncmp(tbname, tmp_file_prefix, tmp_file_prefix_length) == 0) { - return TRUE; - } - if (regex_exclude_list.empty() && regex_include_list.empty() && !tables_include_hash.array &&