Skip to content

Commit 1d84cb2

Browse files
committed
Fix clang-21 -Wunnecessary-virtual-specifier
Member functions of a final class cannot be virtual.
1 parent 4ba1291 commit 1d84cb2

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

sql/ha_partition.h

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -468,11 +468,11 @@ class ha_partition final :public handler
468468
{
469469
return m_is_clone_of;
470470
}
471-
virtual part_id_range *get_part_spec()
471+
part_id_range *get_part_spec()
472472
{
473473
return &m_part_spec;
474474
}
475-
virtual uint get_no_current_part_id()
475+
uint get_no_current_part_id()
476476
{
477477
return NO_CURRENT_PART_ID;
478478
}
@@ -915,7 +915,7 @@ class ha_partition final :public handler
915915
/* Range iterator structure to be supplied to partitions */
916916
RANGE_SEQ_IF m_part_seq_if;
917917

918-
virtual int multi_range_key_create_key(
918+
int multi_range_key_create_key(
919919
RANGE_SEQ_IF *seq,
920920
range_seq_t seq_it
921921
);
@@ -1385,7 +1385,7 @@ class ha_partition final :public handler
13851385
private:
13861386
int reset_auto_increment(ulonglong value) override;
13871387
int update_next_auto_inc_val();
1388-
virtual void lock_auto_increment()
1388+
void lock_auto_increment()
13891389
{
13901390
/* lock already taken */
13911391
if (auto_increment_safe_stmt_log_lock)
@@ -1397,7 +1397,7 @@ class ha_partition final :public handler
13971397
auto_increment_lock= TRUE;
13981398
}
13991399
}
1400-
virtual void unlock_auto_increment()
1400+
void unlock_auto_increment()
14011401
{
14021402
/*
14031403
If auto_increment_safe_stmt_log_lock is true, we have to keep the lock.
@@ -1410,7 +1410,7 @@ class ha_partition final :public handler
14101410
part_share->unlock_auto_inc();
14111411
}
14121412
}
1413-
virtual void set_auto_increment_if_higher(Field *field)
1413+
void set_auto_increment_if_higher(Field *field)
14141414
{
14151415
ulonglong nr= (((Field_num*) field)->unsigned_flag ||
14161416
field->val_int() > 0) ? field->val_int() : 0;

storage/csv/ha_tina.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,7 @@ class ha_tina final : public handler
126126
*/
127127
double scan_time() override { return (double) (stats.records+stats.deleted) / 20.0+10; }
128128
/* The next method will never be called */
129-
virtual bool fast_key_read() { return 1;}
129+
bool fast_key_read() { return 1;}
130130
/*
131131
TODO: return actual upper bound of number of records in the table.
132132
(e.g. save number of records seen on full table scan and/or use file size

0 commit comments

Comments
 (0)