ma_loghandler: translog_set_only_in_buffers failed to release lock

grooverdan · svoj · commit 2328860379eb · 2017-07-03T13:14:05.000+04:00
Release the lock for the error path.

Found by Coverity (id 972093).
diff --git a/storage/maria/ma_loghandler.c b/storage/maria/ma_loghandler.c
@@ -2292,10 +2292,11 @@ static void translog_set_only_in_buffers(TRANSLOG_ADDRESS in_buffers)
   if (cmp_translog_addr(in_buffers, log_descriptor.in_buffers_only) > 0)
   {
     if (translog_status != TRANSLOG_OK)
-      DBUG_VOID_RETURN;
+      goto end;
     log_descriptor.in_buffers_only= in_buffers;
     DBUG_PRINT("info", ("set new in_buffers_only"));
   }
+end:
   mysql_mutex_unlock(&log_descriptor.sent_to_disk_lock);
   DBUG_VOID_RETURN;
 }

Original file line number	Diff line number	Diff line change
`@@ -2292,10 +2292,11 @@ static void translog_set_only_in_buffers(TRANSLOG_ADDRESS in_buffers)`
`2292`	`2292`	`if (cmp_translog_addr(in_buffers, log_descriptor.in_buffers_only) > 0)`
`2293`	`2293`	`{`
`2294`	`2294`	`if (translog_status != TRANSLOG_OK)`
`2295`		`- DBUG_VOID_RETURN;`
	`2295`	`+ goto end;`
`2296`	`2296`	`log_descriptor.in_buffers_only= in_buffers;`
`2297`	`2297`	`DBUG_PRINT("info", ("set new in_buffers_only"));`
`2298`	`2298`	`}`
	`2299`	`+end:`
`2299`	`2300`	`mysql_mutex_unlock(&log_descriptor.sent_to_disk_lock);`
`2300`	`2301`	`DBUG_VOID_RETURN;`
`2301`	`2302`	`}`