Skip to content

Commit

Permalink
Innodb, Windows : Reenable compiler optimizations for mem0mem.cc
Browse files Browse the repository at this point in the history
Compiler optimizations were switched off due to
MySQL Bug #19424, #36366, #34297, due to an alleged compiler bug.
No  proper analysis of code generation was done back then, thus proof of
a compiler bug is missing.

Even if there was a compiler bug 13 years ago, it could have been fixed.
Will wait and see if there are any complains or crashes
  • Loading branch information
vaintroub committed Feb 8, 2018
1 parent 6c5d364 commit 627d33d
Showing 1 changed file with 0 additions and 7 deletions.
7 changes: 0 additions & 7 deletions storage/innobase/innodb.cmake
Expand Up @@ -233,13 +233,6 @@ IF(CMAKE_CXX_COMPILER_ID MATCHES "SunPro"
PROPERTIES COMPILE_FLAGS -xO3)
ENDIF()

# Removing compiler optimizations for innodb/mem/* files on 64-bit Windows
# due to 64-bit compiler error, See MySQL Bug #19424, #36366, #34297
IF (MSVC AND CMAKE_SIZEOF_VOID_P EQUAL 8)
SET_SOURCE_FILES_PROPERTIES(mem/mem0mem.cc mem/mem0pool.cc
PROPERTIES COMPILE_FLAGS -Od)
ENDIF()

# Avoid generating Hardware Capabilities due to crc32 instructions
IF(CMAKE_SYSTEM_NAME MATCHES "SunOS" AND CMAKE_SYSTEM_PROCESSOR MATCHES "i386")
INCLUDE(${MYSQL_CMAKE_SCRIPT_DIR}/compile_flags.cmake)
Expand Down

0 comments on commit 627d33d

Please sign in to comment.