Skip to content
Permalink
Browse files
MDEV-29996 Duplicated call to buf_page_t::set_ibuf_exist() on recovery
mlog_init_t::mark_ibuf_exist(): After applying the changes,
invoke clear().

It turns out that multiple calls to recv_sys.apply(true) are
possible during recovery. Therefore, we might redundantly
invoke mlog_init_t::mark_ibuf_exist() multiple times.

Starting with commit aaef2e1
the call buf_page_t::set_ibuf_exist() is not idempotent,
because the flag is actually represented by 2 values of a
3-bit state field.
  • Loading branch information
dr-m committed Nov 10, 2022
1 parent da21f3f commit 67f4ba2
Showing 1 changed file with 1 addition and 0 deletions.
@@ -1148,6 +1148,7 @@ class mlog_init_t
}

mtr.commit();
clear();
}

/** Clear the data structure */

0 comments on commit 67f4ba2

Please sign in to comment.