Skip to content
Permalink
Browse files
MDEV-23399 fixup: Remove double-free of a buffer page
In commit 7cffb5f we changed the
interface of buf_page_create() so that the free_block is allocated
by the caller. Both calls to buf_LRU_block_free_non_file_page()
should have been removed.

This caused an assertion failure 'block->page.state() == BUF_BLOCK_MEMORY'
in buf_LRU_block_free_non_file_page().

The bug only affected ROW_FORMAT=COMPRESSED pages.
  • Loading branch information
dr-m committed Oct 16, 2020
1 parent bdbec5a commit 6dc037a
Showing 1 changed file with 0 additions and 1 deletion.
@@ -3827,7 +3827,6 @@ buf_page_create(fil_space_t *space, uint32_t offset,
if (block->page.io_fix() != BUF_IO_NONE)
{
hash_lock->write_unlock();
buf_LRU_block_free_non_file_page(free_block);
mysql_mutex_unlock(&buf_pool.mutex);
goto loop;
}

0 comments on commit 6dc037a

Please sign in to comment.