gcc 8 warnings

MariaDB · Apr 2, 2019 · 79fe175 · 79fe175
1 parent f3adfcb
commit 79fe175
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/sql/sql_alloc.h b/sql/sql_alloc.h
@@ -45,9 +45,6 @@ class Sql_alloc
 #ifdef HAVE_valgrind
   bool dummy_for_valgrind;
   inline Sql_alloc() :dummy_for_valgrind(0) {}
-#else
-  inline Sql_alloc() {}
 #endif
-  inline ~Sql_alloc() {}
 };
 #endif /* SQL_ALLOC_INCLUDED */
diff --git a/sql/table.cc b/sql/table.cc
@@ -59,6 +59,8 @@ struct extra2_fields
   LEX_CUSTRING field_flags;
   LEX_CUSTRING system_period;
   LEX_CUSTRING application_period;
+  void reset()
+  { bzero((void*)this, sizeof(*this)); }
 };
 
 static Virtual_column_info * unpack_vcol_info_from_frm(THD *, MEM_ROOT *,
@@ -1451,7 +1453,7 @@ bool read_extra2(const uchar *frm_image, size_t len, extra2_fields *fields)
 
   DBUG_ENTER("read_extra2");
 
-  memset(fields, 0, sizeof(extra2_fields));
+  fields->reset();
 
   if (*extra2 != '/')   // old frm had '/' there
   {