Skip to content
Permalink
Browse files
MDEV-18859 Server crashes in bitmap_bits_set / pack_row / THD::binlog…
…_write_row upon DELETE .. FOR PORTION with binary logging

rpl_write_set is initialized in TABLE::mark_columns_per_binlog_row_image.
Since we just call use_all_columns for PORTION OF case, no need in
column marking logic here. Instead, initialize table->rpl_write_set in
place.
  • Loading branch information
FooBarrior authored and vuvova committed Apr 2, 2019
1 parent 0405506 commit 7e3e2d0
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 0 deletions.
@@ -1,4 +1,5 @@
source suite/period/engines.inc;
source include/have_log_bin.inc;

create or replace table t (id int, s date, e date, period for apptime(s,e));

@@ -718,9 +718,14 @@ bool mysql_delete(THD *thd, TABLE_LIST *table_list, COND *conds,
goto got_error;

if (table_list->has_period())
{
table->use_all_columns();
table->rpl_write_set= table->write_set;
}
else
{
table->mark_columns_needed_for_delete();
}

if ((table->file->ha_table_flags() & HA_CAN_FORCE_BULK_DELETE) &&
!table->prepare_triggers_for_delete_stmt_or_event())

0 comments on commit 7e3e2d0

Please sign in to comment.