Skip to content
Permalink
Browse files
MDEV-23558: Galera heap-buffer-overflow at wsrep_schema.cc:1067
Key buffer needs to contain max field widths i.e. add MAX_FIELD_WIDTH.
  • Loading branch information
Jan Lindström committed Aug 25, 2020
1 parent a16f492 commit 88e70f4
Showing 1 changed file with 3 additions and 3 deletions.
@@ -935,7 +935,7 @@ int Wsrep_schema::update_fragment_meta(THD* thd,

Wsrep_schema_impl::binlog_off binlog_off(thd);
int error;
uchar key[MAX_KEY_LENGTH];
uchar key[MAX_KEY_LENGTH+MAX_FIELD_WIDTH];
key_part_map key_map= 0;
TABLE* frag_table= 0;

@@ -997,7 +997,7 @@ static int remove_fragment(THD* thd,
seqno.get());
int ret= 0;
int error;
uchar key[MAX_KEY_LENGTH];
uchar key[MAX_KEY_LENGTH+MAX_FIELD_WIDTH];
key_part_map key_map= 0;

DBUG_ASSERT(server_id.is_undefined() == false);
@@ -1120,7 +1120,7 @@ int Wsrep_schema::replay_transaction(THD* orig_thd,
int ret= 1;
int error;
TABLE* frag_table= 0;
uchar key[MAX_KEY_LENGTH];
uchar key[MAX_KEY_LENGTH+MAX_FIELD_WIDTH];
key_part_map key_map= 0;

for (std::vector<wsrep::seqno>::const_iterator i= fragments.begin();

0 comments on commit 88e70f4

Please sign in to comment.