Skip to content

Commit 90bea7c

Browse files
author
Jan Lindström
committed
MDEV-23613 : galera_sr.galera_sr_kill_slave MTR failed: query 'LOCK TABLE t2 WRITE' failed: 1146: Table 'test.t2' doesn't exist
Remove unnecessary sleeps from test and replace them with proper wait_conditions.
1 parent 66ae50a commit 90bea7c

File tree

2 files changed

+27
-22
lines changed

2 files changed

+27
-22
lines changed

mysql-test/suite/galera_sr/r/galera_sr_kill_slave.result

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,9 @@ connection node_2;
22
connection node_1;
33
CREATE TABLE t1 (f1 INTEGER PRIMARY KEY) ENGINE=InnoDB;
44
connection node_2;
5-
SELECT COUNT(*) = 0 FROM t1;
6-
COUNT(*) = 0
7-
1
5+
SELECT COUNT(*) AS EXPECT_0 FROM t1;
6+
EXPECT_0
7+
0
88
connection node_1;
99
CREATE TABLE t2 (f1 INTEGER);
1010
connect node_2a, 127.0.0.1, root, , test, $NODE_MYPORT_2;
@@ -39,16 +39,16 @@ INSERT INTO t1 VALUES (13);
3939
INSERT INTO t1 VALUES (14);
4040
INSERT INTO t1 VALUES (15);
4141
COMMIT;
42-
SELECT COUNT(*) = 0 FROM mysql.wsrep_streaming_log;
43-
COUNT(*) = 0
44-
1
42+
SELECT COUNT(*) AS EXPECT_0 FROM mysql.wsrep_streaming_log;
43+
EXPECT_0
44+
0
4545
connection node_2;
46-
SELECT COUNT(*) = 15 FROM t1;
47-
COUNT(*) = 15
48-
1
49-
SELECT COUNT(*) = 0 FROM mysql.wsrep_streaming_log;
50-
COUNT(*) = 0
51-
1
46+
SELECT COUNT(*) AS EXPECT_15 FROM t1;
47+
EXPECT_15
48+
15
49+
SELECT COUNT(*) AS EXPECT_0 FROM mysql.wsrep_streaming_log;
50+
EXPECT_0
51+
0
5252
connection node_1;
5353
DROP TABLE t1;
5454
DROP TABLE t2;

mysql-test/suite/galera_sr/t/galera_sr_kill_slave.test

Lines changed: 15 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -13,12 +13,17 @@ CREATE TABLE t1 (f1 INTEGER PRIMARY KEY) ENGINE=InnoDB;
1313
# Block node #2's applier before table t1's inserts have come into play
1414

1515
--connection node_2
16-
SELECT COUNT(*) = 0 FROM t1;
16+
--let $wait_condition = SELECT COUNT(*) = 1 FROM INFORMATION_SCHEMA.TABLES WHERE TABLE_NAME = 't1'
17+
--source include/wait_condition.inc
18+
SELECT COUNT(*) AS EXPECT_0 FROM t1;
1719

1820
--connection node_1
1921
CREATE TABLE t2 (f1 INTEGER);
2022

2123
--connect node_2a, 127.0.0.1, root, , test, $NODE_MYPORT_2
24+
--let $wait_condition = SELECT COUNT(*) = 1 FROM INFORMATION_SCHEMA.TABLES WHERE TABLE_NAME = 't2'
25+
--source include/wait_condition.inc
26+
2227
LOCK TABLE t2 WRITE;
2328

2429
--connection node_1
@@ -39,11 +44,8 @@ INSERT INTO t1 VALUES (3);
3944
INSERT INTO t1 VALUES (4);
4045
INSERT INTO t1 VALUES (5);
4146

42-
--sleep 2
43-
4447
--connection node_2
4548
--source include/kill_galera.inc
46-
--sleep 1
4749

4850
--connection node_1
4951
INSERT INTO t1 VALUES (6);
@@ -54,8 +56,6 @@ INSERT INTO t1 VALUES (10);
5456

5557
--connection node_2
5658
--source include/start_mysqld.inc
57-
--sleep 1
58-
5959
--source include/wait_until_connected_again.inc
6060
--source include/galera_wait_ready.inc
6161

@@ -67,12 +67,17 @@ INSERT INTO t1 VALUES (14);
6767
INSERT INTO t1 VALUES (15);
6868
COMMIT;
6969

70-
SELECT COUNT(*) = 0 FROM mysql.wsrep_streaming_log;
70+
--let $wait_condition = SELECT COUNT(*) = 0 FROM mysql.wsrep_streaming_log
71+
--source include/wait_condition.inc
72+
73+
SELECT COUNT(*) AS EXPECT_0 FROM mysql.wsrep_streaming_log;
7174

7275
--connection node_2
73-
--sleep 5
74-
SELECT COUNT(*) = 15 FROM t1;
75-
SELECT COUNT(*) = 0 FROM mysql.wsrep_streaming_log;
76+
--let $wait_condition = SELECT COUNT(*) = 15 FROM t1
77+
--source include/wait_condition.inc
78+
79+
SELECT COUNT(*) AS EXPECT_15 FROM t1;
80+
SELECT COUNT(*) AS EXPECT_0 FROM mysql.wsrep_streaming_log;
7681

7782
--connection node_1
7883

0 commit comments

Comments
 (0)