Skip to content

Commit

Permalink
Add missing comment and remove unnecessary initialization
Browse files Browse the repository at this point in the history
- Commit c8948b0 introduced `get_one_variable()` - updating missing argument.
- Remove caller setting of empty string in `rpl_filter`, since underlying functions will do the same
  (commit 9584cbe introduced).

Reviewed by: <brandon.nesterenko@mariadb.com>
  • Loading branch information
an3l committed Sep 14, 2022
1 parent 16b2bb9 commit b7928f7
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 1 deletion.
1 change: 1 addition & 0 deletions sql/sql_show.cc
Original file line number Diff line number Diff line change
Expand Up @@ -3581,6 +3581,7 @@ union Any_pointer {
@param variable [in] Details of the variable.
@param value_type [in] Variable type.
@param show_type [in] Variable show type.
@param status_var [in] Status variable pointer
@param charset [out] Character set of the value.
@param buff [in,out] Buffer to store the value.
(Needs to have enough memory
Expand Down
1 change: 0 additions & 1 deletion sql/sys_vars.cc
Original file line number Diff line number Diff line change
Expand Up @@ -4985,7 +4985,6 @@ Sys_var_rpl_filter::global_value_ptr(THD *thd,
}

rpl_filter= mi->rpl_filter;
tmp.length(0);

mysql_mutex_lock(&LOCK_active_mi);
switch (opt_id) {
Expand Down

0 comments on commit b7928f7

Please sign in to comment.