Skip to content
Permalink
Browse files
Revert "MDEV-23776 Test encryption.create_or_replace fails with a war…
…ning"

This reverts commit e33f7b6.
The change seems to have introduced intermittent failures of the test
encryption.innodb-bad-key-change on many platforms.

The failure that we were trying to address was not reproduced on 10.2.
It could be related to commit a7dd7c8
(MDEV-23651) or de942c9 (MDEV-15983)
or other changes that reduced contention on fil_system.mutex in 10.3.

The fix that we are hereby reverting from 10.2 seems to work fine
on 10.3 and 10.4.
  • Loading branch information
dr-m committed Sep 22, 2020
1 parent e05650e commit eb38b1f
Showing 1 changed file with 0 additions and 6 deletions.
@@ -1483,11 +1483,6 @@ static bool fil_crypt_find_space_to_rotate(
{
/* we need iops to start rotating */
while (!state->should_shutdown() && !fil_crypt_alloc_iops(state)) {
if (state->space && state->space->is_stopping()) {
fil_space_release(state->space);
state->space = NULL;
}

os_event_reset(fil_crypt_threads_event);
os_event_wait_time(fil_crypt_threads_event, 100000);
}
@@ -2511,7 +2506,6 @@ fil_space_crypt_close_tablespace(

/* wakeup throttle (all) sleepers */
os_event_set(fil_crypt_throttle_sleep_event);
os_event_set(fil_crypt_threads_event);

os_thread_sleep(20000);
dict_mutex_enter_for_mysql();

0 comments on commit eb38b1f

Please sign in to comment.