Skip to content

Commit eeb8ebb

Browse files
Daniele SciasciaJan Lindström
authored andcommitted
MDEV-29774 BF abort no longer wakes up debug_sync waiters
Since commit d7d3ad6, "hard" kill is required to interrupt debug sync waits. Affected the following tests: - galera_var_retry_autocommit, - galera_bf_abort_at_after_statement - galera_parallel_apply_3nodes Reviewed-by: Jan Lindström <jan.lindstrom@mariadb.com>
1 parent 8d91e3f commit eeb8ebb

File tree

4 files changed

+2
-5
lines changed

4 files changed

+2
-5
lines changed

mysql-test/suite/galera/disabled.def

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@
1111
##############################################################################
1212

1313
galera_as_slave_ctas : MDEV-28378 timeout
14-
galera_bf_abort_at_after_statement : Timeout in wait_condition.inc for SELECT COUNT(*) = 1 FROM t1 where id = 1 and val = 3
1514
galera_pc_recovery : MDEV-25199 cluster fails to start up
1615
galera_sst_encrypted : MDEV-29876 Galera test failure on galera_sst_encrypted
1716
MW-284 : MDEV-29861 Galera test case hangs

mysql-test/suite/galera_3nodes/disabled.def

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,6 @@
1313

1414
galera_2_cluster : MDEV-29877 Galera test failure on galera_2_cluster
1515
galera_gtid_2_cluster : MDEV-29877 Galera test failure on galera_2_cluster
16-
galera_parallel_apply_3nodes : MDEV-29368 DEBUG_SYNC timeout
17-
galera_parallel_apply_3nodes : MDEV-29774 Galera test galera_parallel_apply_3nodes is unstable
1816
galera_vote_rejoin_mysqldump : MDEV-24481: galera_3nodes.galera_vote_rejoin_mysqldump MTR failed: mysql_shutdown failed
1917
galera_2_cluster : MDEV-29877 Galera test failure on galera_2_cluster
2018
galera_gtid_2_cluster : MDEV-29877 Galera test failure on galera_2_cluster

sql/service_wsrep.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -257,7 +257,7 @@ extern "C" my_bool wsrep_thd_bf_abort(THD *bf_thd, THD *victim_thd,
257257
}
258258

259259
victim_thd->wsrep_aborter= bf_thd->thread_id;
260-
victim_thd->awake_no_mutex(KILL_QUERY);
260+
victim_thd->awake_no_mutex(KILL_QUERY_HARD);
261261
}
262262
else
263263
WSREP_DEBUG("wsrep_thd_bf_abort skipped awake for %llu", thd_get_thread_id(victim_thd));

sql/sp_head.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1497,7 +1497,7 @@ sp_head::execute(THD *thd, bool merge_da_on_success)
14971497
wsrep_current_error_status(thd));
14981498
thd->wsrep_cs().reset_error();
14991499
/* Reset also thd->killed if it has been set during BF abort. */
1500-
if (thd->killed == KILL_QUERY)
1500+
if (killed_mask_hard(thd->killed) == KILL_QUERY)
15011501
thd->killed= NOT_KILLED;
15021502
/* if failed transaction was not replayed, must return with error from here */
15031503
if (!must_replay) err_status = 1;

0 commit comments

Comments
 (0)