Skip to content

Commit fc77fc8

Browse files
committed
Fixed Galera test regressions from 10.3 merge
* Made galera_3nodes.galera_ipv6_mariabackup deterministic with respect to donor selection, fixed assert grep definitions to match Galera 4 behavior and recorded. * Removed extra connection setup from galera_3nodes.galera_ipv6_mysqldump and recorded.
1 parent a3a8947 commit fc77fc8

File tree

5 files changed

+24
-12
lines changed

5 files changed

+24
-12
lines changed

mysql-test/suite/galera_3nodes/r/galera_ipv6_mariabackup.result

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
connection node_2;
2+
connection node_1;
13
SELECT VARIABLE_VALUE LIKE '%[::1]%' FROM INFORMATION_SCHEMA.GLOBAL_STATUS WHERE VARIABLE_NAME = 'wsrep_incoming_addresses';
24
VARIABLE_VALUE LIKE '%[::1]%'
35
1
@@ -19,4 +21,4 @@ connection node_1;
1921
include/assert_grep.inc [Streaming the backup to joiner at \[::1\]]
2022
include/assert_grep.inc [async IST sender starting to serve tcp://\[::1\]:]
2123
include/assert_grep.inc [IST receiver addr using tcp://\[::1\]]
22-
include/assert_grep.inc [Prepared IST receiver, listening at: tcp://\[::1\]]
24+
include/assert_grep.inc [Prepared IST receiver for 3-6, listening at: tcp://\[::1\]]

mysql-test/suite/galera_3nodes/r/galera_ipv6_mysqldump.result

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
connection node_2;
2+
connection node_1;
13
call mtr.add_suppression("WSREP: wsrep_sst_method is set to 'mysqldump' yet mysqld bind_address is set to'");
24
call mtr.add_suppression("Failed to load slave replication state from table mysql.gtid_slave_pos");
35
connection node_1;
@@ -33,5 +35,6 @@ CALL mtr.add_suppression("Can't open and lock time zone table");
3335
CALL mtr.add_suppression("Can't open and lock privilege tables");
3436
CALL mtr.add_suppression("Info table is not ready to be used");
3537
CALL mtr.add_suppression("Native table .* has the wrong structure");
38+
CALL mtr.add_suppression("Table \'mysql.gtid_slave_pos\' doesn\'t exist");
3639
connection node_2;
3740
CALL mtr.add_suppression("Unsupported protocol downgrade: incremental data collection disabled. Expect abort");

mysql-test/suite/galera_3nodes/t/galera_ipv6_mariabackup.cnf

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,18 +10,23 @@ wsrep-cluster-address=gcomm://
1010
wsrep_provider_options='base_host=[::1];base_port=@mysqld.1.#galera_port;gmcast.listen_addr=tcp://[::]:@mysqld.1.#galera_port;ist.recv_addr=[::1]:@mysqld.1.#ist_port'
1111
wsrep_sst_receive_address='[::1]:@mysqld.1.#sst_port'
1212
wsrep_node_incoming_address='[::1]:@mysqld.1.port'
13+
wsrep_node_name=node_1
1314

1415
[mysqld.2]
1516
wsrep_cluster_address='gcomm://[::1]:@mysqld.1.#galera_port'
1617
wsrep_provider_options='base_host=[::1];base_port=@mysqld.2.#galera_port;gmcast.listen_addr=tcp://[::]:@mysqld.2.#galera_port;ist.recv_addr=[::1]:@mysqld.2.#ist_port'
1718
wsrep_sst_receive_address='[::1]:@mysqld.2.#sst_port'
1819
wsrep_node_incoming_address='[::1]:@mysqld.2.port'
20+
wsrep_node_name=node_2
21+
wsrep_sst_donor=node_1
1922

2023
[mysqld.3]
2124
wsrep_cluster_address='gcomm://[::1]:@mysqld.1.#galera_port'
2225
wsrep_provider_options='base_host=[::1];base_port=@mysqld.3.#galera_port;gmcast.listen_addr=tcp://[::]:@mysqld.3.#galera_port;ist.recv_addr=[::1]:@mysqld.3.#ist_port'
2326
wsrep_sst_receive_address='[::1]:@mysqld.3.#sst_port'
2427
wsrep_node_incoming_address='[::1]:@mysqld.3.port'
28+
wsrep_node_name=node_3
29+
wsrep_sst_donor=node_1
2530

2631
[SST]
2732
transferfmt=@ENV.MTR_GALERA_TFMT

mysql-test/suite/galera_3nodes/t/galera_ipv6_mariabackup.test

Lines changed: 13 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
--source include/galera_cluster.inc
2-
--source include/have_ipv6.inc
2+
--source include/check_ipv6.inc
33
--source include/have_mariabackup.inc
44

55
# Confirm that initial handshake happened over ipv6
@@ -38,22 +38,31 @@ DROP TABLE t1;
3838
--let $assert_file = $MYSQLTEST_VARDIR/log/mysqld.1.err
3939
--let $assert_only_after = CURRENT_TEST
4040

41+
# The SSTs happen when nodes are started first time
4142
--let $assert_count = 2
4243
--let $assert_text = Streaming the backup to joiner at \[::1\]
4344
--let $assert_select = Streaming the backup to joiner at \[::1\]
4445
--source include/assert_grep.inc
4546

46-
--let $assert_count = 1
47+
# There will be 3 ISTs donated from node_1 in Galera 4.
48+
# Two first happen at the initial startup to populate the certification
49+
# index. The third one is from the IST which happens during the actual test.
50+
--let $assert_count = 3
4751
--let $assert_text = async IST sender starting to serve tcp://\[::1\]:
4852
--let $assert_select = async IST sender starting to serve tcp://\[::1\]:
4953
--source include/assert_grep.inc
5054

5155
--let $assert_file = $MYSQLTEST_VARDIR/log/mysqld.2.err
5256

57+
# There are two ISTs on joiner, the first at the initial startup, the second
58+
# during the actual test.
59+
--let $assert_count = 2
5360
--let $assert_text = IST receiver addr using tcp://\[::1\]
5461
--let $assert_select = IST receiver addr using tcp://\[::1\]
5562
--source include/assert_grep.inc
5663

57-
--let $assert_text = Prepared IST receiver, listening at: tcp://\[::1\]
58-
--let $assert_select = Prepared IST receiver, listening at: tcp://\[::1\]
64+
# The receiver expects seqnos 3-6 only once.
65+
--let $assert_count = 1
66+
--let $assert_text = Prepared IST receiver for 3-6, listening at: tcp://\[::1\]
67+
--let $assert_select = Prepared IST receiver for 3-6, listening at: tcp://\[::1\]
5968
--source include/assert_grep.inc

mysql-test/suite/galera_3nodes/t/galera_ipv6_mysqldump.test

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,6 @@
11
--source include/galera_cluster.inc
22
--source include/check_ipv6.inc
33

4-
--connect node_3, 127.0.0.1, root, , test, $NODE_MYPORT_3
5-
# Save original auto_increment_offset values.
6-
--let $node_1=node_1
7-
--let $node_2=node_2
8-
--let $node_3=node_3
9-
--source ../galera/include/auto_increment_offset_save.inc
10-
114
call mtr.add_suppression("WSREP: wsrep_sst_method is set to 'mysqldump' yet mysqld bind_address is set to'");
125
call mtr.add_suppression("Failed to load slave replication state from table mysql.gtid_slave_pos");
136

0 commit comments

Comments
 (0)