Skip to content
Permalink
Browse files
MDEV-26146: The test main.limit_rows_examined fails in case it is run…
… in PS mode.

Test failed by firing assert in append_warnings() when it is called
from run_query_stmt() and there are more results from server.

Obviously, append_warnings() should be called after the last packet
received from server. So, to fix the assertion failure the function
mysql_more_results() has to be called to check that now more results
does exist and invokes append_warnings() in case the condition satisfied.
  • Loading branch information
dmitryshulga committed Jul 14, 2021
1 parent 04369f9 commit ff0d3bb
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 6 deletions.
@@ -8416,7 +8416,7 @@ void run_query_stmt(struct st_connection *cn, struct st_command *command,
append_session_track_info(ds, mysql);


if (!disable_warnings)
if (!disable_warnings && !mysql_more_results(stmt->mysql))
{
/* Get the warnings from execute */

@@ -2,11 +2,6 @@
# Tests for LIMIT ROWS EXAMINED, MDEV-28
#

if (`SELECT $PS_PROTOCOL != 0`)
{
--skip Test temporarily disabled for ps-protocol
}

--source include/default_optimizer_switch.inc
call mtr.add_suppression("Sort aborted.*");

0 comments on commit ff0d3bb

Please sign in to comment.