From ffbb2bbc09e7fc8c0f60d5c42ce521b4c31c94a7 Mon Sep 17 00:00:00 2001 From: Alexander Barkov Date: Thu, 2 Feb 2017 15:05:20 +0400 Subject: [PATCH] Removing redundant tests for "SET (global|local|session).varname" This is covered in mysql-test/t/variables.test. There is no sense to test this for every individual variables. This is to reduce the coming soon patch for ROW-type routine variables, which will change the error from ER_PARSE_ERROR to a new error "unknown structured variable". --- .../r/automatic_sp_privileges_basic.result | 4 ---- .../suite/sys_vars/r/big_tables_basic.result | 4 ---- .../sys_vars/r/binlog_cache_size_basic.result | 2 -- .../r/binlog_stmt_cache_size_basic.result | 2 -- .../r/bulk_insert_buffer_size_basic.result | 4 ---- .../r/character_set_client_basic.result | 2 -- .../r/character_set_connection_basic.result | 2 -- .../r/character_set_database_basic.result | 2 -- .../r/character_set_filesystem_basic.result | 2 -- .../r/character_set_results_basic.result | Bin 16480 -> 16253 bytes .../r/character_set_server_basic.result | 2 -- .../r/collation_connection_basic.result | 2 -- .../r/collation_database_basic.result | 2 -- .../sys_vars/r/collation_server_basic.result | 2 -- .../sys_vars/r/completion_type_basic.result | 4 ---- .../sys_vars/r/concurrent_insert_basic.result | 2 -- .../sys_vars/r/connect_timeout_basic.result | 2 -- .../r/default_master_connection_basic.result | 4 ---- .../r/default_week_format_basic.result | 4 ---- .../r/delayed_insert_limit_basic.result | 4 ---- .../r/delayed_insert_timeout_basic.result | 4 ---- .../r/delayed_queue_size_basic.result | 4 ---- .../r/div_precision_increment_basic.result | 4 ---- .../sys_vars/r/event_scheduler_basic.result | 4 ---- .../sys_vars/r/expire_logs_days_basic.result | 4 ---- .../suite/sys_vars/r/flush_basic.result | 2 -- .../suite/sys_vars/r/general_log_basic.result | 4 ---- .../suite/sys_vars/r/identity_basic.result | 4 ---- .../suite/sys_vars/r/insert_id_basic.result | 4 ---- .../sys_vars/r/key_buffer_size_basic.result | 4 ---- .../r/key_cache_age_threshold_basic.result | 4 ---- .../r/key_cache_block_size_basic.result | 4 ---- .../r/key_cache_division_limit_basic.result | 4 ---- .../r/key_cache_file_hash_size_basic.result | 4 ---- .../sys_vars/r/lc_time_names_basic.result | 2 -- .../sys_vars/r/local_infile_basic.result | 2 -- .../r/max_binlog_cache_size_basic.result | 4 ---- .../sys_vars/r/max_binlog_size_basic.result | 4 ---- .../r/max_binlog_stmt_cache_size_basic.result | 4 ---- .../r/max_connect_errors_basic.result | 4 ---- .../sys_vars/r/max_connections_basic.result | 4 ---- .../r/max_prepared_stmt_count_basic.result | 4 ---- .../r/max_relay_log_size_basic.result | 4 ---- .../r/myisam_stats_method_basic.result | 4 ---- .../r/mysql56_temporal_format_basic.result | 2 -- .../suite/sys_vars/r/old_mode_basic.result | 4 ---- .../sys_vars/r/query_cache_limit_basic.result | 4 ---- .../r/query_cache_min_res_unit_basic.result | 4 ---- .../sys_vars/r/query_cache_size_basic.result | 4 ---- .../suite/sys_vars/r/read_only_basic.result | 4 ---- .../sys_vars/r/relay_log_purge_basic.result | 2 -- .../r/slave_max_allowed_packet_basic.result | 4 ---- .../sys_vars/r/slow_launch_time_basic.result | 4 ---- .../sys_vars/r/slow_query_log_basic.result | 4 ---- .../suite/sys_vars/r/sql_mode_basic.result | 4 ---- .../suite/sys_vars/r/sync_binlog_basic.result | 4 ---- .../suite/sys_vars/r/sync_frm_basic.result | 2 -- .../r/table_definition_cache_basic.result | 2 -- .../sys_vars/r/table_open_cache_basic.result | 2 -- .../sys_vars/r/tx_isolation_basic.result | 4 ---- .../t/automatic_sp_privileges_basic.test | 4 ---- .../suite/sys_vars/t/big_tables_basic.test | 4 ---- .../sys_vars/t/binlog_cache_size_basic.test | 2 -- .../t/binlog_stmt_cache_size_basic.test | 2 -- .../t/bulk_insert_buffer_size_basic.test | 4 ---- .../t/character_set_client_basic.test | 2 -- .../t/character_set_connection_basic.test | 2 -- .../t/character_set_database_basic.test | 2 -- .../t/character_set_filesystem_basic.test | 3 --- .../t/character_set_results_basic.test | 3 --- .../t/character_set_server_basic.test | 3 --- .../t/collation_connection_basic.test | 3 --- .../sys_vars/t/collation_database_basic.test | 3 --- .../sys_vars/t/collation_server_basic.test | 3 --- .../sys_vars/t/completion_type_basic.test | 4 ---- .../sys_vars/t/concurrent_insert_basic.test | 2 -- .../sys_vars/t/connect_timeout_basic.test | 2 -- .../t/default_master_connection_basic.test | 4 ---- .../sys_vars/t/default_week_format_basic.test | 4 ---- .../t/delayed_insert_limit_basic.test | 4 ---- .../t/delayed_insert_timeout_basic.test | 4 ---- .../sys_vars/t/delayed_queue_size_basic.test | 4 ---- .../t/div_precision_increment_basic.test | 4 ---- .../sys_vars/t/event_scheduler_basic.test | 4 ---- .../sys_vars/t/expire_logs_days_basic.test | 4 ---- mysql-test/suite/sys_vars/t/flush_basic.test | 2 -- .../suite/sys_vars/t/general_log_basic.test | 4 ---- .../suite/sys_vars/t/identity_basic.test | 4 ---- .../suite/sys_vars/t/insert_id_basic.test | 4 ---- .../sys_vars/t/key_buffer_size_basic.test | 4 ---- .../t/key_cache_age_threshold_basic.test | 4 ---- .../t/key_cache_block_size_basic.test | 4 ---- .../t/key_cache_division_limit_basic.test | 4 ---- .../t/key_cache_file_hash_size_basic.test | 4 ---- .../suite/sys_vars/t/lc_time_names_basic.test | 3 --- .../suite/sys_vars/t/local_infile_basic.test | 2 -- .../t/max_binlog_cache_size_basic.test | 4 ---- .../sys_vars/t/max_binlog_size_basic.test | 4 ---- .../t/max_binlog_stmt_cache_size_basic.test | 4 ---- .../sys_vars/t/max_connect_errors_basic.test | 4 ---- .../sys_vars/t/max_connections_basic.test | 4 ---- .../t/max_prepared_stmt_count_basic.test | 4 ---- .../sys_vars/t/max_relay_log_size_basic.test | 4 ---- .../sys_vars/t/myisam_stats_method_basic.test | 5 ----- .../t/mysql56_temporal_format_basic.test | 2 -- .../suite/sys_vars/t/old_mode_basic.test | 5 ----- .../sys_vars/t/query_cache_limit_basic.test | 4 ---- .../t/query_cache_min_res_unit_basic.test | 4 ---- .../sys_vars/t/query_cache_size_basic.test | 4 ---- .../suite/sys_vars/t/read_only_basic.test | 4 ---- .../sys_vars/t/relay_log_purge_basic.test | 2 -- .../t/slave_max_allowed_packet_basic.test | 4 ---- .../sys_vars/t/slow_launch_time_basic.test | 4 ---- .../sys_vars/t/slow_query_log_basic.test | 4 ---- .../suite/sys_vars/t/sql_mode_basic.test | 5 ----- .../suite/sys_vars/t/sync_binlog_basic.test | 4 ---- .../suite/sys_vars/t/sync_frm_basic.test | 2 -- .../t/table_definition_cache_basic.test | 2 -- .../sys_vars/t/table_open_cache_basic.test | 2 -- .../suite/sys_vars/t/tx_isolation_basic.test | 4 ---- 120 files changed, 404 deletions(-) diff --git a/mysql-test/suite/sys_vars/r/automatic_sp_privileges_basic.result b/mysql-test/suite/sys_vars/r/automatic_sp_privileges_basic.result index 98072169fc94d..760cca254977a 100644 --- a/mysql-test/suite/sys_vars/r/automatic_sp_privileges_basic.result +++ b/mysql-test/suite/sys_vars/r/automatic_sp_privileges_basic.result @@ -84,12 +84,8 @@ SELECT @@automatic_sp_privileges = @@global.automatic_sp_privileges; '#---------------------FN_DYNVARS_004_10----------------------#' SET automatic_sp_privileges = 1; ERROR HY000: Variable 'automatic_sp_privileges' is a GLOBAL variable and should be set with SET GLOBAL -SET local.automatic_sp_privileges = 1; -ERROR 42000: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'automatic_sp_privileges = 1' at line 1 SELECT local.automatic_sp_privileges; ERROR 42S02: Unknown table 'local' in field list -SET global.automatic_sp_privileges = 1; -ERROR 42000: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'automatic_sp_privileges = 1' at line 1 SELECT global.automatic_sp_privileges; ERROR 42S02: Unknown table 'global' in field list SELECT automatic_sp_privileges = @@session.automatic_sp_privileges; diff --git a/mysql-test/suite/sys_vars/r/big_tables_basic.result b/mysql-test/suite/sys_vars/r/big_tables_basic.result index 4ff5774812a91..29781987d477c 100644 --- a/mysql-test/suite/sys_vars/r/big_tables_basic.result +++ b/mysql-test/suite/sys_vars/r/big_tables_basic.result @@ -86,12 +86,8 @@ SET big_tables = 1; SELECT @@big_tables; @@big_tables 1 -SET local.big_tables = 1; -ERROR 42000: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'big_tables = 1' at line 1 SELECT local.big_tables; ERROR 42S02: Unknown table 'local' in field list -SET session.big_tables = 1; -ERROR 42000: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'big_tables = 1' at line 1 SELECT session.big_tables; ERROR 42S02: Unknown table 'session' in field list select big_tables; diff --git a/mysql-test/suite/sys_vars/r/binlog_cache_size_basic.result b/mysql-test/suite/sys_vars/r/binlog_cache_size_basic.result index d83caffb5bed0..680e62162a78a 100644 --- a/mysql-test/suite/sys_vars/r/binlog_cache_size_basic.result +++ b/mysql-test/suite/sys_vars/r/binlog_cache_size_basic.result @@ -96,8 +96,6 @@ SELECT @@binlog_cache_size = @@global.binlog_cache_size; '#---------------------FN_DYNVARS_006_09----------------------#' SET binlog_cache_size = 1; ERROR HY000: Variable 'binlog_cache_size' is a GLOBAL variable and should be set with SET GLOBAL -SET global.binlog_cache_size = 1; -ERROR 42000: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'binlog_cache_size = 1' at line 1 SELECT global.binlog_cache_size; ERROR 42S02: Unknown table 'global' in field list SELECT binlog_cache_size = @@session.binlog_cache_size; diff --git a/mysql-test/suite/sys_vars/r/binlog_stmt_cache_size_basic.result b/mysql-test/suite/sys_vars/r/binlog_stmt_cache_size_basic.result index 94519d3cd23e3..f16a36eefa4c1 100644 --- a/mysql-test/suite/sys_vars/r/binlog_stmt_cache_size_basic.result +++ b/mysql-test/suite/sys_vars/r/binlog_stmt_cache_size_basic.result @@ -96,8 +96,6 @@ SELECT @@binlog_stmt_cache_size = @@global.binlog_stmt_cache_size; '#---------------------FN_DYNVARS_006_09----------------------#' SET binlog_stmt_cache_size = 1; ERROR HY000: Variable 'binlog_stmt_cache_size' is a GLOBAL variable and should be set with SET GLOBAL -SET global.binlog_stmt_cache_size = 1; -ERROR 42000: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'binlog_stmt_cache_size = 1' at line 1 SELECT global.binlog_stmt_cache_size; ERROR 42S02: Unknown table 'global' in field list SELECT binlog_stmt_cache_size = @@session.binlog_stmt_cache_size; diff --git a/mysql-test/suite/sys_vars/r/bulk_insert_buffer_size_basic.result b/mysql-test/suite/sys_vars/r/bulk_insert_buffer_size_basic.result index 1b8e000ad8157..97083da70338f 100644 --- a/mysql-test/suite/sys_vars/r/bulk_insert_buffer_size_basic.result +++ b/mysql-test/suite/sys_vars/r/bulk_insert_buffer_size_basic.result @@ -133,12 +133,8 @@ SET bulk_insert_buffer_size = 1; SELECT @@bulk_insert_buffer_size; @@bulk_insert_buffer_size 1 -SET local.bulk_insert_buffer_size = 1; -ERROR 42000: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'bulk_insert_buffer_size = 1' at line 1 SELECT local.bulk_insert_buffer_size; ERROR 42S02: Unknown table 'local' in field list -SET session.bulk_insert_buffer_size = 1; -ERROR 42000: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'bulk_insert_buffer_size = 1' at line 1 SELECT session.bulk_insert_buffer_size; ERROR 42S02: Unknown table 'session' in field list SELECT bulk_insert_buffer_size = @@session.bulk_insert_buffer_size; diff --git a/mysql-test/suite/sys_vars/r/character_set_client_basic.result b/mysql-test/suite/sys_vars/r/character_set_client_basic.result index e6502d63c78ec..749e669dd2625 100644 --- a/mysql-test/suite/sys_vars/r/character_set_client_basic.result +++ b/mysql-test/suite/sys_vars/r/character_set_client_basic.result @@ -21,8 +21,6 @@ SET character_set_client=utf8; SELECT @@session.character_set_client; @@session.character_set_client utf8 -SET global.character_set_client=utf8; -ERROR 42000: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'character_set_client=utf8' at line 1 SET session character_set_client=utf8; SELECT session character_set_client; ERROR 42S22: Unknown column 'session' in 'field list' diff --git a/mysql-test/suite/sys_vars/r/character_set_connection_basic.result b/mysql-test/suite/sys_vars/r/character_set_connection_basic.result index ad9e9c8090263..ee550ee105ff9 100644 --- a/mysql-test/suite/sys_vars/r/character_set_connection_basic.result +++ b/mysql-test/suite/sys_vars/r/character_set_connection_basic.result @@ -21,8 +21,6 @@ SET character_set_connection=utf8; SELECT @@session.character_set_connection; @@session.character_set_connection utf8 -SET global.character_set_connection=utf8; -ERROR 42000: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'character_set_connection=utf8' at line 1 SET session character_set_connection=utf8; SELECT session character_set_connection; ERROR 42S22: Unknown column 'session' in 'field list' diff --git a/mysql-test/suite/sys_vars/r/character_set_database_basic.result b/mysql-test/suite/sys_vars/r/character_set_database_basic.result index 2fec211cf8d18..4ced92315605e 100644 --- a/mysql-test/suite/sys_vars/r/character_set_database_basic.result +++ b/mysql-test/suite/sys_vars/r/character_set_database_basic.result @@ -21,8 +21,6 @@ SET character_set_database=utf8; SELECT @@session.character_set_database; @@session.character_set_database utf8 -SET global.character_set_database=utf8; -ERROR 42000: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'character_set_database=utf8' at line 1 SET session character_set_database=utf8; SELECT session character_set_database; ERROR 42S22: Unknown column 'session' in 'field list' diff --git a/mysql-test/suite/sys_vars/r/character_set_filesystem_basic.result b/mysql-test/suite/sys_vars/r/character_set_filesystem_basic.result index c1a77b73fb347..7a32f92deebf9 100644 --- a/mysql-test/suite/sys_vars/r/character_set_filesystem_basic.result +++ b/mysql-test/suite/sys_vars/r/character_set_filesystem_basic.result @@ -21,8 +21,6 @@ SET character_set_filesystem=utf8; SELECT @@session.character_set_filesystem; @@session.character_set_filesystem utf8 -SET global.character_set_filesystem=utf8; -ERROR 42000: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'character_set_filesystem=utf8' at line 1 SET session character_set_filesystem=utf8; SELECT session character_set_filesystem; ERROR 42S22: Unknown column 'session' in 'field list' diff --git a/mysql-test/suite/sys_vars/r/character_set_results_basic.result b/mysql-test/suite/sys_vars/r/character_set_results_basic.result index 244fa4670b8d93cdddab7b3ca71ede8645ccd78a..7fc498fa7359fe9c033a0fb1cb48bff0f903d80b 100644 GIT binary patch delta 21 dcmaFR!1%Xr!&RoqkC|mB*D~>Ke#~5J0|0Ym32XoW delta 194 zcmXZUv5LY#6op}u#@0r*Q8=A#6bo6k5$#+SV`X`XH)c?0