Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MDEV-14580: mysql_install_db elements based on dirname of mysql_instal_db #1086

Closed

Conversation

grooverdan
Copy link
Member

tested with the following with cwd at builddir:

$ make DESTDIR=/tmp/m3 install
$  /tmp/m3/usr/local/mysql/scripts/mysql_install_db --datadir=/tmp/data_fullpath
$ mv /tmp/m3 /tmp/m4
$ /tmp/m4/usr/local/mysql/scripts/mysql_install_db --datadir=/tmp/data_moved
$ export PATH=/tmp/m4/usr/local/mysql/scripts:$PATH
$  mysql_install_db --datadir=/tmp/data_path
$ cd  /tmp/m4/usr/local/mysql/scripts
$ ./mysql_install_db --datadir /tmp/relative

I submit this under the MCA.

@an3l an3l added the license-mca Contributed under the MCA label Jan 12, 2019
@an3l an3l added this to the 10.3 milestone Jan 12, 2019
@an3l an3l requested a review from vuvova January 12, 2019 13:12
vuvova pushed a commit that referenced this pull request Jan 14, 2019
@vuvova vuvova self-assigned this Jan 14, 2019
@vuvova
Copy link
Member

vuvova commented Jan 14, 2019

I've merged it into 5.5 (bb-5.5-serg for now) with a follow-up commit to remove additional dependencies. The history taught me that mysql_install_db is quite brittle, so I'd try to avoid adding anything that it doesn't use now. I've replaced $(...) syntax with backticks and added some safety checks in case dirname isn't available.

Hope it's ok.

@grooverdan
Copy link
Member Author

fine. looks good. thanks for the merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
license-mca Contributed under the MCA
3 participants