check_linker_flag: use for linker flags #1525
Conversation
cmake/check_linker_flag.cmake
Outdated
| # TODO - SET(HAVE_SHARED..) is temporary only. remove once | ||
| # MY_CHECK_SHARED_LINKER_FLAG perfoms independent check. | ||
| SET(HAVE_SHARED_${result} HAVE_MODULE_${result}) | ||
| FOREACH(linktype SHARED MODULE) |
There was a problem hiding this comment.
What about CMAKE_EXE_LINKER_FLAGS? Do you think it's not needed here?
There was a problem hiding this comment.
Good call, it is needed.
cmake/check_linker_flag.cmake
Outdated
| #The regex patterns above are not localized, thus LANG=C | ||
| SET(ENV{LANG} C) | ||
|
|
||
| MACRO (MY_CHECK_MODULE_LINKER_FLAG flag) |
There was a problem hiding this comment.
Why "MODULE", How does it check specifically for MODULE?
There was a problem hiding this comment.
This was the WIP bit, waiting for a clue to see how to test module vs shared library vs exe . I couldn't immediately see one, so was keeping it separate for now. If your happy with just this implementation I can rename/merge it with MY_CHECK_LINKER_FLAG.
cmake/check_linker_flag.cmake
Outdated
| ENDMACRO() | ||
|
|
||
| FUNCTION(MY_CHECK_AND_SET_LINKER_FLAG flag_to_set) | ||
| # At the moment this is gcc-only. |
There was a problem hiding this comment.
not really "gcc-only", is it? 😄 just remove this line
cmake/check_linker_flag.cmake
Outdated
| FAIL_REGEX "warning:.*ignored" | ||
| FAIL_REGEX "warning:.*is valid for.*but not for" | ||
| FAIL_REGEX "warning:.*redefined" | ||
| FAIL_REGEX "[Ww]arning: [Oo]ption" |
There was a problem hiding this comment.
Not sure you need all these patterns here
There was a problem hiding this comment.
nope, but I've no idea how linkers would issue warnings and these seem to be reasonable texts for now.
-Wl,-z,relro,-z,now are linker flags and should be checked as such. TODO: perform module, exe shared checks separately rather than a pure linker check.
grooverdan
force-pushed
the
10.1-WIP-check-and-set-linker-flag
branch
from
f4d0a9f
to
fb1d30c
Compare
|
Ready now. In the absence of a clear way to separate module, shared, exe tests, just assumed the linker can take the same flags in all scenarios. So this has been simplified down. fail regexs removed until a case is needed, and added the EXE_FLAGS. |
|
Well no-one's come up with a good module/linker/exe test separately (https://stackoverflow.com/questions/61604663/how-do-i-test-cmake-shared-linker-flags-and-cmake-module-linker-flags), so is thi ok @vuvova ? |
|
Thanks for the patch! |
|
Thanks for the merge. |
Fixes noisy clang output like #1524
Treats "-Wl,-z,relro,-z,now" as an actual linker flags rather than compile flags.
Slightly WIP due to being a purely linker check rather than testing module and shared library builds separately, however it does have an advantage over #1524 in that the linker flags are still used in clang.