MCOL-4057: Package ColumnStore 10.5 for Debian #1605
Conversation
ottok
force-pushed
the
ok-10.5-cs
branch
2 times, most recently
from
967bffc
to
340ef7c
Compare
ottok
changed the title
|
@drrtuy This is now ready for review. |
debian/control
Outdated
| libsnappy1 | libsnappy1v5, | ||
| mariadb-server-10.5 (= ${binary:Version}), | ||
| net-tools, | ||
| python, |
There was a problem hiding this comment.
After a lot of thinking we decide this will be python3 since the next release not python2.
There was a problem hiding this comment.
This references automatically the latest Python version. You cannot use Python 2 on new software anymore, it has been removed from Ubuntu and Debian.
Related, please update all scripts to have the header #!/usr/bin/python3, don't use deprecated env thing.
|
Buildbot at http://buildbot.askmonty.org/buildbot/grid?branch=ok-10.5-cs&category=main&category=experimental is passing fine and also Travis-CI at https://travis-ci.org/github/ottok/mariadb/builds/702641457 is green. I am not aware of any regressions and I have no further work on this one planned. Please review and merge on 10.5. This is kind of urgent, since the packaging was not done properly before the 10.5.4 release and should be fixed ASAP. |
|
Rebased, fixed python dependency conflict. Ready to merge again. @drrtuy |
ottok
force-pushed
the
ok-10.5-cs
branch
4 times, most recently
from
c2011d0
to
df9faad
Compare
- Add 'libboost-all-dev' and 'libreadline-gplv2-dev' as they were was found
to be a compulsory build dependency for columnstore plugin.
- Add 'expect' as run-time dependencey for columnstore plugin as scripts
use it:
usr/bin/mcs_module_installer.sh: #!/usr/bin/expect
usr/bin/remote_command.sh: #!/usr/bin/expect
usr/bin/remote_command_verify.sh: #!/usr/bin/expect
usr/bin/remote_scp_get.sh: #!/usr/bin/expect
usr/bin/remote_scp_put.sh: #!/usr/bin/expect
usr/bin/rsync.sh: #!/usr/bin/expect
- Properly define depends on Python. No Python 2 support needs to be
considered, Python 3 has been around long enough. Fixes Lintian errors
E: mariadb-plugin-columnstore: python-script-but-no-python-dep
usr/bin/mcs-loadbrm.py #!python
E: mariadb-plugin-columnstore: python-script-but-no-python-dep
usr/bin/mcs-start-storagemanager.py #!python
- Partially revert undocumented and thus unjustified changes in commits
d69a79d and
c056566.
- Trigger ldconfig, otherwise Lintian complains:
E: mariadb-plugin-columnstore: package-must-activate-ldconfig-trigger
usr/lib/x86_64-linux-gnu/libwriteengineredistribute.so
- Update postinst to be compatible with new server binary mariadbd name.
- Properly detect systemd or fallback to sysv init in postrm script.
- Only attempt to build ColumnStore on amd64 and i386. Test builds on
Launchpad.net showed the CMake plugin configure step will prevent even
attempts to build on other platforms.
- Clean up and unify cmake build command in debian/rules.
- Explicitly list files not installed.
- Run 'wrap-and-sort -a -v'.
- Truncate build logs on Salsa-CI to keep under 4 MB. This is now needed
as the ColumnStore build is so verbose.
See https://jira.mariadb.org/browse/MCOL-4111.
- Update Travis-CI dependencies to match new debian/control.
|
This was done with urgency originally, but now stalled for weeks. There was already one review (just not re-review) and CI does not detect any regressions, so should be safe to merge. Proceeding with it now. |
No description provided.