MDEV-505: feature request: add \H option for mysql client prompt #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce `\H` option which behaves mostly like `\h`. The only exception is when the client connects to the server hosted on localhost. In this case, the hostname will be used instead.
|
Hi Dan, This task was added to 10.2.0 backlog, which hasn't been scheduled yet. I can guess it will be around May 2016. Thanks, |
| break; | ||
| const char *prompt; | ||
| prompt= connected ? mysql_get_host_info(&mysql) : "not_connected"; | ||
| if (strstr(prompt, "Localhost")) |
There was a problem hiding this comment.
Original patch had strstr("localhost") as well, it was supposed for "localhost" connections via TCP/IP. Not sure if it makes sense though.
|
Pushed eca0607 |
vuvova
pushed a commit
that referenced
this pull request
Jun 22, 2017
vuvova
added a commit
that referenced
this pull request
Jun 22, 2017
dr-m
pushed a commit
that referenced
this pull request
Nov 10, 2017
vuvova
added a commit
that referenced
this pull request
Dec 4, 2017
dr-m
pushed a commit
that referenced
this pull request
Dec 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MDEV-505: feature request: add \H option for mysql client prompt
Introduce
\Hoption which behaves mostly like\h. The only exception iswhen the client connects to the server hosted on localhost. In this case, the
hostname will be used instead.
I already sent my MCA so the developers of MariaDB may use this patch however they consider best.
Best regards,
Dan Ungureanu